Skip to content

Fix overlay only mode #5401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marta-lokhova merged 2 commits into from
Aug 4, 2026
Merged

Fix overlay only mode #5401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ec523e
Fix overlay-only loadgen mode with overlay v2, force CI to run loadge…
marta-lokhova Aug 1, 2026
14faa77
Removed commented out test file
marta-lokhova Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ echo "Using RND_SEED: $RND_SEED"
ulimit -n 65536
export INTERACTIVE=0

export TEST_SPEC='[overlay-ipc]'
export TEST_SPEC='[overlay-ipc],[loadgen]'
export SKIP_SOROBAN_TESTS=true
export STELLAR_OVERLAY_BINARY="${SRC_DIR}/build-${CC}-${PROTOCOL}/stellar-overlay"
time make check
Expand Down
6 changes: 0 additions & 6 deletions src/herder/HerderImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,12 +666,6 @@ HerderImpl::recvTransaction(TransactionFrameBasePtr tx, bool submittedFromSelf,
CLOG_TRACE(Herder, "recv transaction {} for {}",
hexAbbrev(tx->getFullHash()),
KeyUtils::toShortString(tx->getSourceID()));
#ifdef BUILD_TESTS
if (submittedFromSelf)
{
mLedgerManager.recordTxSubmission(tx->getContentsHash());
}
#endif
Comment thread
marta-lokhova marked this conversation as resolved.

auto const& env = tx->getEnvelope();
mApp.getOverlayManager().broadcastTransaction(env, tx->getFullFee(),
Expand Down
1 change: 0 additions & 1 deletion src/herder/PendingEnvelopes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ class PendingEnvelopes
// Returns true if every tx set referenced by `env` is available locally
bool areTxSetsFetched(SCPEnvelope const& env) const;


SCPEnvelopeWrapperPtr pop(uint64 slotIndex);

// erases data for all slots outside the range [minSlot, maxSlot].
Expand Down
Loading
Loading