Stack thread - #5398
Open
graydon wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a cross-platform StackThread abstraction with configurable stack sizes and uses it to standardize BatchExecutor worker stacks at 8 MiB.
Changes:
- Implements thread lifecycle, naming, IDs, and native handles.
- Migrates BatchExecutor workers from
std::thread. - Adds StackThread unit tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/util/StackThread.h |
Implements the configurable-stack thread abstraction. |
src/util/test/StackThreadTests.cpp |
Tests thread API behavior and Linux stack sizing. |
src/util/BatchExecutor.h |
Changes worker storage to StackThread. |
src/util/BatchExecutor.cpp |
Creates workers with 8 MiB stacks. |
Comments suppressed due to low confidence (1)
src/util/StackThread.h:546
pthread_createmay run the trampoline before returning, whilemThread,mJoinable, andmIdare assigned only afterward. A callable that captures theStackThreadunder construction can observe or race with those writes, unlikestd::thread's constructor synchronization guarantee. Gatepayload->run()on a startup barrier that is released only after all object state has been published.
rc = ::pthread_create(&tid, &attr, &detail::trampoline, payload.get());
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new StackThread type that works like std::thread but takes a stack size as first argument. It then uses that in BatchExecutor with an 8MiB stack. The point here is just to avoid worker-thread stack size variability across platforms, which we've seen from time to time in the past.