Fail noisily if an unknown --enable or --disable flag is passed to configure - #5395
Open
graydon wants to merge 1 commit into
Open
Fail noisily if an unknown --enable or --disable flag is passed to configure#5395graydon wants to merge 1 commit into
graydon wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Makes top-level configuration fail on misspelled or unknown feature flags while preserving permissive recursive configuration.
Changes:
- Sets Autoconf option checking to
fatal. - Documents why recursive sub-configures remain unaffected.
dmkozh
approved these changes
Jul 29, 2026
dmkozh
left a comment
dmkozh
left a comment
Contributor
There was a problem hiding this comment.
That's very much appreciated, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If, like me, you regularly mis-spell a configure --enable-foo or --disable-foo flag and it gets silently ignored, you might enjoy this PR: it enables a thing in autoconf that catches and complains about such misspellings rather than silently ignoring them!
(Apparently this is normally the default until you have sub-configures like we have, in which case it switches. But you can switch it back. Thanks robot for discovering this!)
Fixes #2635