Fix two bugs - #1
Merged
Merged
Conversation
Member
|
Thank you. Sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make state_machines-yard work in my project (and everywhere, I'd say), I needed to introduce two patches as seen here:
https://github.com/openSUSE/travel-support-program/blob/master/lib/fix_state_machine_yard.rb
This pull request should fix both (with two separate commits): a inconsistent use of the new namespace StateMachines and a fragile handling of conditional transitions, like already explained here pluginaweek/state_machine#283
With this modifications, I'm able to remove my monkey patching and the gem works like a charm for me. So it would be great if you can release an updated version.
Thanks.