-
-
Notifications
You must be signed in to change notification settings - Fork 14
chore: Sync the vendored UI with upstream antora-ui-default, part 2: JS and a11y ports #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
41d51d9
define nav variable in nav script so it's available to showNav even i…
mojavelinux 8a05e6e
only call highlightBlock on code element with data-lang attribute
mojavelinux 7002d1a
clean up copy to clipboard script; pass UI root path as data attribute
mojavelinux 7e719b9
Break edit-this-page out into separate partial
ferdnyc d58566e
comment out unused uiRootPath variable assignment
mojavelinux 1d7a6ee
allow page-pagination to be set to next or prev to fine-tune which di…
mojavelinux 9696c97
add fallbacks in scripts if HTML document does not have article.doc
mojavelinux 58dfc21
add aria- attributes to mobile menu button
mojavelinux 7df2b01
replace data-target with aria-controls (but check for data-target as …
mojavelinux eefdc7b
resolves #72 add toggle expand/collapse all button to nav
mojavelinux 93d6992
resolves #168 don't lock scrolling after resizing when a mobile menu …
mojavelinux 844e9f5
provide better fallback for uiRootPath in copy to clipboard script
mojavelinux 4d545ac
hide expand/collapse button on nav if there are no expandable items
mojavelinux 367d847
move nav menu toggle button outside of conditional for component title
mojavelinux 67ce09f
hide nav toggle button if nav container is absent
mojavelinux 39f4932
feat(a11y): Give the mobile menu button an accessible name and aria s…
lfrancke 46b0794
fix: Guard against a missing toolbar in the fragment jumper
lfrancke 649b2c5
Update ui/src/css/header.css
lfrancke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| {{#if (and page.fileUri (not env.CI))}} | ||
| <div class="edit-this-page"><a href="{{page.fileUri}}">Edit this Page</a></div> | ||
| {{else if (and page.editUrl (or env.FORCE_SHOW_EDIT_PAGE_LINK (not page.origin.private)))}} | ||
| <div class="edit-this-page"><a href="{{page.editUrl}}">Edit this Page</a></div> | ||
| {{/if}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,4 +21,6 @@ | |
| </script> | ||
| --> | ||
| {{/with}} | ||
| {{!-- | ||
| <script>var uiRootPath = '{{{uiRootPath}}}'</script> | ||
| --}} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,16 @@ | ||
| {{#unless (eq page.attributes.pagination undefined)}} | ||
| {{#if (or page.previous page.next)}} | ||
| <nav class="pagination" data-pagefind-ignore> | ||
| {{#if (ne page.attributes.pagination 'next')}} | ||
| {{#with page.previous}} | ||
| <span class="prev"><a href="{{{relativize ./url}}}">{{{./content}}}</a></span> | ||
| {{/with}} | ||
| {{/if}} | ||
| {{#if (ne page.attributes.pagination 'prev')}} | ||
| {{#with page.next}} | ||
| <span class="next"><a href="{{{relativize ./url}}}">{{{./content}}}</a></span> | ||
| {{/with}} | ||
| {{/if}} | ||
| </nav> | ||
| {{/if}} | ||
| {{/unless}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.