fix(property): 검색 조건 지역 집계 반영 - #95
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughAdds optional ChangesKeyword search and region marker counts
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@backend/src/main/java/com/ssafy/salmanhae/model/dao/property/JdbcPropertyDao.java`:
- Around line 659-669: The keyword search in JdbcPropertyDao currently binds
user input directly into LIKE, so % and _ are treated as wildcards instead of
literal characters. Update the keywordPattern handling in the hasKeyword block
to escape SQL wildcard characters before putting the value into params, and add
an ESCAPE clause to the LIKE predicates so plain-text searches work correctly
for literal inputs like 100% or _동.
In `@docs/08_API_SPEC.md`:
- Line 107: The API spec entry for keyword is incomplete and does not match the
actual search contract. Update the documentation in the API spec around the
keyword field so it reflects all supported search targets exposed by the
implementation, including title and road_address in addition to building
name/address; make the description consistent wherever keyword is documented.
In `@frontend/src/store/mapStore.js`:
- Line 163: The viewport request in fetchViewport is still sending the raw
searchKeyword even though filteredProperties and hasActiveSearchConditions treat
whitespace-only input as empty. Update fetchViewport in mapStore to trim this
value before building the request payload, and make sure the keyword field uses
the normalized search keyword consistently with the existing search-state
checks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e2ceef47-6866-4431-ba2a-ed63af34072b
📒 Files selected for processing (12)
backend/src/main/java/com/ssafy/salmanhae/controller/map/MapViewportController.javabackend/src/main/java/com/ssafy/salmanhae/controller/property/PropertyController.javabackend/src/main/java/com/ssafy/salmanhae/model/dao/property/JdbcPropertyDao.javabackend/src/main/java/com/ssafy/salmanhae/model/dto/property/PropertySearchCriteria.javabackend/src/test/java/com/ssafy/salmanhae/controller/map/MapViewportControllerTest.javabackend/src/test/java/com/ssafy/salmanhae/controller/property/PropertyControllerTest.javadocs/08_API_SPEC.mdfrontend/src/api/properties.test.mjsfrontend/src/store/mapStore.jsfrontend/src/utils/mapViewport.jsfrontend/src/utils/mapViewport.test.mjsfrontend/src/views/MapExplorer.vue
변경 내용
keyword검색 조건을 추가했습니다.docs/08_API_SPEC.md에keyword파라미터와 지역 집계 동작을 반영했습니다.테스트
cmd /c npm testcmd /c npm run build./mvnw -q -Dtest=MapViewportControllerTest,PropertyControllerTest test./mvnw -q testcloses #94
Summary by CodeRabbit
keywordsearch to map viewport and property listing endpoints.%and_as literal text.keywordparameter and related map display behavior.