fix(map): 지도 줌 계층과 마커 피드백 보정 - #65
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds SIDO_AVG viewport support, generalizes region-average aggregation, and updates frontend selection, labels, marker behavior, tests, and API docs. ChangesSIDO_AVG Viewport Mode — Full Stack
Sequence Diagram(s)sequenceDiagram
participant User
participant MapExplorer
participant mapStore
participant MapViewportServiceImpl
participant JdbcPropertyDao
User->>MapExplorer: open map at low zoom
MapExplorer->>MapViewportServiceImpl: GET /api/v1/map/viewport?zoom=8
MapViewportServiceImpl->>MapViewportServiceImpl: resolveMode(zoom) -> SIDO_AVG
MapViewportServiceImpl->>JdbcPropertyDao: findRegionAverageViewportItems(..., "SIDO", limit)
JdbcPropertyDao-->>MapViewportServiceImpl: region-average items
MapViewportServiceImpl-->>MapExplorer: viewport response with mode and items
User->>MapExplorer: click region marker
MapExplorer->>mapStore: selectViewportItem(item)
MapExplorer-->>User: sidebar summary card and zoom action
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 markdownlint-cli2 (0.22.1)docs/08_API_SPEC.mdmarkdownlint-cli2 v0.22.1 (markdownlint v0.40.0) Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/08_API_SPEC.md`:
- Around line 175-178: The API spec sample is inconsistent with the updated zoom
thresholds, because the example request still uses a zoom level that now maps to
a different mode than the sample response shows. Update the sample
request/response around the documented zoom behavior so the request value, the
returned mode, and the explanation all match the new threshold logic in the API
spec; check the zoom table and the nearby sample block to keep them aligned.
In `@frontend/src/store/mapStore.js`:
- Around line 203-210: The viewport selection in selectViewportItem is sticky
and keeps overriding the property list in MapExplorer.vue, so clear
selectedViewportItem when the viewport refresh transitions to property results
or when the fetch mode becomes PROPERTY_MARKER. Update the state flow around
selectViewportItem and the viewport refresh/fetch handling so
selectedViewportItem is reset once real properties are loaded, allowing the
sidebar to show the new results instead of the summary card.
In `@frontend/src/utils/mapViewport.js`:
- Around line 25-29: The regionLevelLabel mapping currently returns an
inaccurate label for SIDO. Update the regionLevelLabel function so the SIDO
entry uses 시/도 instead of 도, while keeping the other level labels unchanged and
preserving the fallback to 지역.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: abfa1e78-df45-4756-84f7-fa49bfcade0c
📒 Files selected for processing (9)
backend/src/main/java/com/ssafy/salmanhae/model/dao/property/JdbcPropertyDao.javabackend/src/main/java/com/ssafy/salmanhae/model/dto/map/MapViewportMode.javabackend/src/main/java/com/ssafy/salmanhae/service/map/MapViewportServiceImpl.javabackend/src/test/java/com/ssafy/salmanhae/controller/map/MapViewportControllerTest.javadocs/08_API_SPEC.mdfrontend/src/store/mapStore.jsfrontend/src/utils/mapViewport.jsfrontend/src/utils/mapViewport.test.mjsfrontend/src/views/MapExplorer.vue
Summary
Tests
Closes #64
Summary by CodeRabbit