-
Notifications
You must be signed in to change notification settings - Fork 0
fix(map): 넓은 줌 시군구 집계 안정화 #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "status": "completed", | ||
| "phase": "phase5-qa-docs-deploy.md", | ||
| "issue_number": 61, | ||
| "timestamp": "2026-06-24T16:53:00+09:00", | ||
| "detail": "Verified backend and frontend test/build gates, documented the deployment QA probe, and stabilized broad SIGUNGU viewport aggregation for Cloud Run redeploy via develop CI/CD.", | ||
| "runner": "codex" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # Phase 5 QA Report | ||
|
|
||
| ## Scope | ||
|
|
||
| - Issue: #61 | ||
| - Date: 2026-06-24 | ||
| - Target: zoom-aware map viewport flow for F-1 property search | ||
|
|
||
| ## Contract Check | ||
|
|
||
| - `GET /api/v1/map/viewport` remains the frontend map data source. | ||
| - Zoom thresholds remain unchanged: | ||
| - `<= 11`: `SIGUNGU_AVG` | ||
| - `12`-`13`: `DONG_AVG` | ||
| - `14`-`15`: `PROPERTY_CLUSTER` | ||
| - `>= 16`: `PROPERTY_MARKER` | ||
| - `SIGUNGU_AVG` now aggregates active visible properties directly by `sigungu` so broad zoom requests stay small and do not depend on the heavier precomputed region-stat join. | ||
|
|
||
| ## Deployment Probe Before Fix | ||
|
|
||
| Checked the deployed Cloud Run API at: | ||
|
|
||
| `https://salmanhae-api-370583013156.asia-northeast3.run.app/api/v1/map/viewport` | ||
|
|
||
| Using Seoul-wide bounds: | ||
|
|
||
| | zoom | observed status | observed mode | | ||
| | --- | ---: | --- | | ||
| | 9 | 401 | none | | ||
| | 10 | 401 | none | | ||
| | 11 | 401 | none | | ||
| | 12 | 200 | `DONG_AVG` | | ||
| | 14 | 200 | `PROPERTY_CLUSTER` | | ||
| | 16 | 200 | `PROPERTY_MARKER` | | ||
|
|
||
| The failure was limited to the broad `SIGUNGU_AVG` branch. `PROPERTY_CLUSTER` returned 360 cluster items and `PROPERTY_MARKER` returned the existing 500 item cap, so the remaining risk was the broad-region query path. | ||
|
|
||
| ## Local Verification | ||
|
|
||
| Commands run: | ||
|
|
||
| ```bash | ||
| cd backend && ./mvnw.cmd -Dtest=MapViewportControllerTest test | ||
| cd backend && ./mvnw.cmd test | ||
| cd frontend && CI=true pnpm test | ||
| cd frontend && CI=true pnpm build | ||
| python scripts/execute_codex.py map-viewport-zoom --dry-run | ||
| ``` | ||
|
|
||
| Expected after merge: | ||
|
|
||
| - Backend GitHub Actions deploys `salmanhae-api` on `develop` pushes that touch `backend/**`. | ||
| - Vercel deploys the frontend from the existing frontend project integration on `develop`. | ||
| - No new secrets or Cloud Run service changes are required. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.