-
Notifications
You must be signed in to change notification settings - Fork 66
chore: release v1.0.0 - ESM-only, analytical antimeridian splitting, fix antimeridian low npoints split #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 15 commits
5f58c4f
cc9037e
d3598f2
cbf2c4e
a27ad91
19c506a
807167d
98d42e7
496efc6
6e9178d
970148d
b154d4d
b4a8d1d
48fc6d6
86e5376
f2a3623
c5ea41a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "arc", | ||
| "version": "0.2.0", | ||
| "version": "1.0.0", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just a note that we need to add when we do that, we should update the DEVELOPING.md file too. ref: #80
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, let's roll this into the release, so I'll make those changes in the next commit.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed in c5ea41a. |
||
| "description": "draw great circle arcs", | ||
| "url": "https://github.com/springmeyer/arc.js", | ||
| "keywords": [ | ||
|
|
@@ -14,7 +14,8 @@ | |
| ], | ||
| "contributors": [ | ||
| "Dane Springmeyer <dane.springmeyer@gmail.com>", | ||
| "John Gravois <jagravois@gmail.com>" | ||
| "John Gravois <jagravois@gmail.com>", | ||
| "Thomas Hervey <thomasahervey@gmail.com>" | ||
| ], | ||
| "repository": { | ||
| "type": "git", | ||
|
|
@@ -30,8 +31,7 @@ | |
| "dist/", | ||
| "README.md", | ||
| "LICENSE.md", | ||
| "GDAL-LICENSE.md", | ||
| "CHANGELOG.md" | ||
| "CHANGELOG.md" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i know you mentioned adding a new linter/formatter. in the meantime, the whitespace here is a bit borked. |
||
| ], | ||
| "engines": { | ||
| "node": ">=18" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's show an example with
npointsomitted too and make it explicit directly below that the argument is now optional.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. In commit f2a3623 I've updated the README to show examples with and without
npoints