Reassert the scope of the spk-workspace crate - #1396
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
rydrman
marked this pull request as ready for review
July 24, 2026 23:55
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
The workspace crate accumulated framing and dependencies that pointed toward a larger, build-orchestration concept that is not being pursued. This tidies the crate down to what it actually does today: discover recipe spec files and resolve them by name, version, or path. - drop the unused spk-solve dependency (and the orphaned sentry feature that only forwarded to it) and the unused itertools dependency - reword the crate, module, and struct docs that described the unimplemented package build-orchestration vision - add user documentation for workspaces describing the workspace file, recipe globs, and version-parameterized recipes No behavior change. Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
rydrman
force-pushed
the
workspace-scope-cleanup
branch
from
July 24, 2026 23:57
69ca4d3 to
f40a1a9
Compare
jrray
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
spk-workspacecrate had accumulated framing and dependencies that pointed toward a larger, build-orchestration concept (the abandoned "build a network of packages together" direction). This PR tidies the crate down to what it actually does today: discover recipe spec files and resolve them by name, version, or path. It also adds the missing user documentation so workspaces are a clearly-bounded, complete feature that doesn't imply further development.No behavior change. The version-parameterized recipe support (
versions:inworkspace.spk.yaml, e.g. thepackages/python/python{2,3}.spk.yamlrecipes) is intentionally kept, since real specs in this repo rely on it.Changes
spk-solvedependency fromspk-workspace(zero code references; it only existed to forward asentryfeature that nothing enabled) along with the orphanedsentryfeature and the unuseditertoolsdependency.docs/use/workspaces.mddocumenting the workspace file, recipe globs, and version-parameterized recipes.Testing
cargo metadataresolves cleanly with the updated manifest.cargo test -p spk-workspacecould not be run locally: this is a macOS host, and thespfsstack (pulled in transitively viaspk-schema) depends on the Linux-onlyprocfscrate. Relying on CI (Linux) for build/test validation.