contrib/release.sh: do not re-download full dist/ after gpg errors - #10847
Open
SomberNight wants to merge 1 commit into
Open
contrib/release.sh: do not re-download full dist/ after gpg errors#10847SomberNight wants to merge 1 commit into
SomberNight wants to merge 1 commit into
Conversation
When running release.sh as non-RM, with sftp access, `mget *` downloads ~500 MB of data. This takes several minutes for me. On line 299, `gpg --sign` can error, e.g. due human-error with the hardware-security-module, in which case I have to re-run release.sh and redownload 500 MB again. This change allows me to avoid redownloading and to reuse the existing files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running release.sh as non-RM, with sftp access,
mget *downloads ~500 MB of data. This takes several minutes for me. On line 299,gpg --signcan error, e.g. due to human-error with the hardware-security-module, in which case I have to re-run release.sh and redownload 500 MB again.This change allows me to avoid redownloading and to reuse the existing files.