fix(core/link-to-dfn): use parentElement.closest() for scoping hint - #5393
Draft
marcoscaceres wants to merge 1 commit into
Draft
fix(core/link-to-dfn): use parentElement.closest() for scoping hint#5393marcoscaceres wants to merge 1 commit into
marcoscaceres wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5257
elem.closest("[data-link-for]")matches the element itself, so when an<a>hasdata-link-for(for example from[=bar/foo=]syntax), the hint wrongly says the link is "inside" a scoped section when the attribute is on the link itself.Uses
parentElement.closest()to restrict the lookup to ancestors, and guards the empty-string case, sincedata-link-for=""means intentionally unscoped.Written with AI: this change was generated by Claude. Per AI_POLICY.md.