fix(core/ui): guard against string-only messages in the error pill - #5390
Draft
marcoscaceres with Copilot wants to merge 2 commits into
Draft
fix(core/ui): guard against string-only messages in the error pill#5390marcoscaceres with Copilot wants to merge 2 commits into
marcoscaceres with Copilot wants to merge 2 commits into
Conversation
Contributor
|
@copilot can you fix the CI issue related to the title of the PR? |
Copilot
AI
changed the title
[WIP] Fix respec pill not displaying list for string errors
Fix crash when clicking error/warning pill for string messages
Aug 11, 2026
Contributor
Author
The CI check fails because the PR title doesn't follow Conventional Commits (needs a
That should satisfy the "Check PR title" workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking the error/warning pill to view details crashed when a message was a plain string instead of an object, since string messages produce a
DocumentFragmentwith only text nodes (firstElementChild/lastElementChildare bothnull).Root cause
createWarnButtoninsrc/core/ui.jsunconditionally accessedfragment.firstElementChild.childNodeswhenfirstElementChild === lastElementChild, which is also true (null === null) for text-only fragments, causing aTypeErroron click.Fix
firstElementChildactually exists; string messages now fall through to the existing "take everything" branch, appending the raw text fragment to the list item.Tests
tests/spec/core/ui-spec.jsthat raises a string error, clicks the pill, and asserts the modal list renders the message without throwing.