Guard caniuse table rendering against missing .head dl element - #5374
Open
brian-soltani wants to merge 1 commit into
Open
Guard caniuse table rendering against missing .head dl element#5374brian-soltani wants to merge 1 commit into
brian-soltani wants to merge 1 commit into
Conversation
run() assumed document.querySelector(".head dl") always finds an element and used optional chaining on headDlElem to avoid crashing when it doesn't. That silently no-ops instead of surfacing the problem, and it still throws later since headDlElem is read unguarded elsewhere in the function.
This adds an early return with a showWarning() call when the .head dl element isn't found, matching the existing pattern used in implementation-status.js, and removes the now-redundant optional chaining on the two remaining headDlElem accesses.
Closes speced#5370
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run() assumed document.querySelector(".head dl") always finds an element and used optional chaining on headDlElem to avoid crashing when it doesn't. That silently no-ops instead of surfacing the problem, and it still throws later since headDlElem is read unguarded elsewhere in the function.
This adds an early return with a showWarning() call when the .head dl element isn't found, matching the existing pattern used in implementation-status.js, and removes the now-redundant optional chaining on the two remaining headDlElem accesses.
Closes #5370