Skip to content

fix(a11y): name the modal close button and MDN engine icons for AT - #5206

Merged
marcoscaceres merged 2 commits into
mainfrom
fix/batch-a-a11y
Aug 13, 2026
Merged

fix(a11y): name the modal close button and MDN engine icons for AT#5206
marcoscaceres merged 2 commits into
mainfrom
fix/batch-a-a11y

Conversation

@marcoscaceres

@marcoscaceres marcoscaceres commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

The modal close button relied on title="Close", which screen readers do not reliably announce, and the MDN engine support emoji had no accessible name at all. This swaps the former for aria-label and gives the emoji icons role="img" plus an aria-label, so assistive technology announces both.

Written with AI: this change was generated by Claude. Per AI_POLICY.md.

@marcoscaceres
marcoscaceres marked this pull request as ready for review April 18, 2026 09:04
@marcoscaceres
marcoscaceres requested a review from Copilot April 18, 2026 09:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves accessibility and resolves a Firefox issue in the W3C profile by ensuring required UI elements and stylesheets are present and correctly labeled.

Changes:

  • Update modal close button to use aria-label="Close" instead of relying on title.
  • Add role="img" + aria-label to MDN engine-support emoji icons for screen reader compatibility.
  • Ensure the W3C dark.css link is always present (using media="not all" for light-only specs) so fixup.js can safely run theme setup without throwing (issue #5200).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/spec/w3c/style-spec.js Adds/updates assertions around presence and media of the dark.css link.
tests/spec/core/ui-spec.js Adds test ensuring modal close button has an accessible label.
tests/spec/core/mdn-annotation-spec.js Updates tests to assert role="img" and aria-label on engine-support icons.
src/w3c/style.js Always appends dark.css link to avoid fixup.js theme initialization crash.
src/core/ui.js Replaces title with aria-label on the modal close button.
src/core/mdn-annotation.js Adds accessible semantics to emoji-based engine-support indicators.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/w3c/style.js Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/core/mdn-annotation.js Outdated

Copilot AI commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4289 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53567246 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,14012296849460148156,16344405798395175158,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,609967996193249427,1646266379268380415,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53567246 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=53567246 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4876 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-30444975 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5108666763499229750,17683470410975652610,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,8645754712659286064,8526609116824664728,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • android.clients.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4289 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53567246 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,14012296849460148156,16344405798395175158,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,609967996193249427,1646266379268380415,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53567246 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=53567246 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4876 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-30444975 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5108666763499229750,17683470410975652610,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,8645754712659286064,8526609116824664728,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • api.specref.org
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4876 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-30444975 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5108666763499229750,17683470410975652610,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,8645754712659286064,8526609116824664728,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-30444975 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=30444975 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5156 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-10002981 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7633891663380551061,12127382284584777583,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,4156082773621183881,3077925972704500294,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • clients2.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4289 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53567246 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,14012296849460148156,16344405798395175158,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,609967996193249427,1646266379268380415,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53567246 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=53567246 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4876 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-30444975 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5108666763499229750,17683470410975652610,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,8645754712659286064,8526609116824664728,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • clientservices.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4289 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53567246 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,14012296849460148156,16344405798395175158,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,609967996193249427,1646266379268380415,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53567246 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=53567246 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4876 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-30444975 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5108666763499229750,17683470410975652610,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,8645754712659286064,8526609116824664728,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • optimizationguide-pa.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4289 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53567246 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,14012296849460148156,16344405798395175158,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,609967996193249427,1646266379268380415,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53567246 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=53567246 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
  • redirector.gvt1.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4289 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53567246 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,14012296849460148156,16344405798395175158,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,609967996193249427,1646266379268380415,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53567246 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=53567246 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4876 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-30444975 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5108666763499229750,17683470410975652610,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,8645754712659286064,8526609116824664728,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • respec.org
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4876 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-30444975 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5108666763499229750,17683470410975652610,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,8645754712659286064,8526609116824664728,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-30444975 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=30444975 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5156 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-10002981 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7633891663380551061,12127382284584777583,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,4156082773621183881,3077925972704500294,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • safebrowsing.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4289 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53567246 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,14012296849460148156,16344405798395175158,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,609967996193249427,1646266379268380415,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53567246 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=53567246 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
  • safebrowsingohttpgateway.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4289 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53567246 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,14012296849460148156,16344405798395175158,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,609967996193249427,1646266379268380415,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53567246 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=53567246 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4876 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-30444975 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5108666763499229750,17683470410975652610,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,8645754712659286064,8526609116824664728,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • update.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4289 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53567246 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,14012296849460148156,16344405798395175158,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,609967996193249427,1646266379268380415,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53567246 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=53567246 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
  • w3c.github.io
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5156 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-10002981 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7633891663380551061,12127382284584777583,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,4156082773621183881,3077925972704500294,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-10002981 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=10002981 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5369 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-57478618 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,1463143331893950598,4514510342230308701,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,4797976925920148610,13263429608761697847,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • www.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4289 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53567246 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,14012296849460148156,16344405798395175158,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,609967996193249427,1646266379268380415,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53567246 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=53567246 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4876 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-30444975 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5108666763499229750,17683470410975652610,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,8645754712659286064,8526609116824664728,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • www.w3.org
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4876 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-30444975 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5108666763499229750,17683470410975652610,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,8645754712659286064,8526609116824664728,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-30444975 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=30444975 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5156 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-10002981 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7633891663380551061,12127382284584777583,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,4156082773621183881,3077925972704500294,4 --trace-process-track-uuid=3190708989122997041 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@marcoscaceres
marcoscaceres marked this pull request as draft April 19, 2026 12:44
@marcoscaceres

Copy link
Copy Markdown
Contributor Author

@copilot can you take a look at CI and fix the issue?

Copilot AI commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

@copilot can you take a look at CI and fix the issue?

Fixed in 28dd807. I checked the failing CI run and updated the W3C style tests to target the actual rel="stylesheet" dark.css link (instead of the preload hint) and assert its media via getAttribute(), which addresses the failure. Screenshot: no UI changes (test-only fix).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4225 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-96077647 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10781046836488724232,9990117645654302192,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,3965183857159199251,9882356765424423089,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-96077647 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=96077647 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4483 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44618645 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,12156667204980027964,6782812658514897397,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11966707153888343895,2642254546986212502,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • api.specref.org
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4225 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-96077647 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10781046836488724232,9990117645654302192,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,3965183857159199251,9882356765424423089,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-96077647 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=96077647 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4483 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44618645 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,12156667204980027964,6782812658514897397,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11966707153888343895,2642254546986212502,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • clients2.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4225 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-96077647 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10781046836488724232,9990117645654302192,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,3965183857159199251,9882356765424423089,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-96077647 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=96077647 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4483 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44618645 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,12156667204980027964,6782812658514897397,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11966707153888343895,2642254546986212502,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • clientservices.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4225 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-96077647 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10781046836488724232,9990117645654302192,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,3965183857159199251,9882356765424423089,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-96077647 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=96077647 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4483 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44618645 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,12156667204980027964,6782812658514897397,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11966707153888343895,2642254546986212502,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • redirector.gvt1.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4225 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-96077647 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10781046836488724232,9990117645654302192,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,3965183857159199251,9882356765424423089,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-96077647 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=96077647 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4483 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44618645 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,12156667204980027964,6782812658514897397,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11966707153888343895,2642254546986212502,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • respec.org
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4225 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-96077647 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10781046836488724232,9990117645654302192,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,3965183857159199251,9882356765424423089,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-96077647 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=96077647 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4483 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44618645 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,12156667204980027964,6782812658514897397,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11966707153888343895,2642254546986212502,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • safebrowsingohttpgateway.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4225 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-96077647 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10781046836488724232,9990117645654302192,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,3965183857159199251,9882356765424423089,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-96077647 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=96077647 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4483 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44618645 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,12156667204980027964,6782812658514897397,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11966707153888343895,2642254546986212502,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • www.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4225 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-96077647 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10781046836488724232,9990117645654302192,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,3965183857159199251,9882356765424423089,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-96077647 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=96077647 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4483 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44618645 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,12156667204980027964,6782812658514897397,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11966707153888343895,2642254546986212502,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • www.w3.org
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4225 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-96077647 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10781046836488724232,9990117645654302192,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,3965183857159199251,9882356765424423089,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-96077647 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications http://localhost:9876/?id=96077647 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4483 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44618645 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,12156667204980027964,6782812658514897397,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11966707153888343895,2642254546986212502,4 --trace-process-track-uuid=3190708989122997041 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@marcoscaceres

Copy link
Copy Markdown
Contributor Author

@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed?

Copilot AI commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed?

Confirmed: all prior feedback is addressed in this branch. I rechecked the a11y updates (aria-label on close button, decorative MDN spacer) and the theme-toggle fix path (dark.css handling), and there are no remaining unaddressed review items. Latest relevant branch CI for HEAD 3528637 is green (Node CI (PR), CodeQL, and PR title checks), so no additional code fixes were needed. Screenshot: no UI changes in this verification pass.

@marcoscaceres
marcoscaceres marked this pull request as ready for review May 9, 2026 02:40
@marcoscaceres
marcoscaceres requested a review from sidvishnoi May 9, 2026 02:41
Comment thread src/w3c/style.js
@marcoscaceres marcoscaceres added the AI Contains AI-generated logic; see AI_POLICY.md label Aug 5, 2026
@marcoscaceres marcoscaceres changed the title fix(a11y): accessible labels for close button, MDN icons; fix Firefox theme toggle fix(a11y): name the modal close button and MDN engine icons for AT Aug 13, 2026
@marcoscaceres
marcoscaceres merged commit 5f969e3 into main Aug 13, 2026
9 checks passed
@marcoscaceres
marcoscaceres deleted the fix/batch-a-a11y branch August 13, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Contains AI-generated logic; see AI_POLICY.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants