feat: sync grading table filters and selectors to URL with nuqs - #4330
Draft
RichDom2185 wants to merge 7 commits into
Draft
feat: sync grading table filters and selectors to URL with nuqs#4330RichDom2185 wants to merge 7 commits into
RichDom2185 wants to merge 7 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closed
2 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wires
nuqsinto the grading overview page so the table filters and dropdown selectors live in the URL — making a filtered/searched view shareable and reload-safe (previously all localuseState, with a Redux mirror for the column filters).nuqsdependency and mountNuqsAdapter(nuqs/adapters/react-router/v8) inRootLayout, inside the react-router data-router tree whereuseSearchParamsis available.Grading.tsx→useQueryState:?showAll,?myGroups(dynamic default!isAdmin && group !== null),?pageSize.?filters(JSON) and the assessment-name search →?searchinGradingSubmissionsTable.tsx.columnFiltersand remove the now-redundantsubmissionsTableFiltersRedux state (action / reducer / type / initial state / unit test) in its own commit.Note: the
filtersparser (and its[]default) is defined at module scope so the default keeps a stable reference across renders — otherwise a fresh[]each render would spuriously changecolumnFiltersand trigger a refetch loop.Type of change
How to test
yarn tsc -b— passes.yarn test— full suite green (759 tests / 91 files)./courses/:courseId/grading, thenshowAll/myGroups/pageSize;search;filtersround-trips (theprogressStatusauto-strip still fires when not showing all submissions);Checklist
🤖 Generated with Claude Code