Skip to content

[landscape] obfuscate registration_key in client.conf - #4467

Open
realstuffie wants to merge 1 commit into
sosreport:mainfrom
realstuffie:landscape-registration-key
Open

[landscape] obfuscate registration_key in client.conf#4467
realstuffie wants to merge 1 commit into
sosreport:mainfrom
realstuffie:landscape-registration-key

Conversation

@realstuffie

Copy link
Copy Markdown

landscape-client writes registration_key rather than registration_password, so the existing substitution no longer matched and the credential was collected in clear text. The replacement also dropped the separator, producing malformed output when it did match.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • [ X] Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • [ X] Is the subject and message clear and concise?
  • [ X] Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • [ X] Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • [ X] Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • [X ] Are all passwords or private data gathered by this PR obfuscated?

@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/sosreport-sos-4467
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@realstuffie
realstuffie force-pushed the landscape-registration-key branch 2 times, most recently from 61f9c4d to cb7ebc5 Compare August 30, 2026 20:48
landscape-client writes registration_key rather than
registration_password, so the existing substitution no longer
matched and the credential was collected in clear text. The
replacement also dropped the separator, producing malformed
output when it did match.

Signed-off-by: Thomas Moore <sales@mooresolutions.co.nz>
@realstuffie
realstuffie force-pushed the landscape-registration-key branch from cb7ebc5 to 8cbb641 Compare August 30, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant