fix(engine): support Node 10 query parsing#5528
Open
tianrking wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5527.
Engine.IO advertises support for Node.js 10.2+, but both the standard HTTP server and the uWebSockets server parsed query strings with
Object.fromEntries(), which was only added in Node.js 12. A polling handshake therefore threw before validation on supported Node 10 deployments.Replace those calls with a shared
URLSearchParamsparser that usesObject.defineProperty. It preserves the previous last-value-wins behavior for duplicate keys and keeps__proto__as an ordinary own property rather than mutating the query object's prototype.Tests
Object.fromEntriesand verifies a polling handshake still succeeds.npm run compile --workspace=engine.ionpx mocha --bail --exit test/server.js --grep 'without Object.fromEntries'npx prettier --check lib/server.ts lib/userver.ts test/server.jsnpx mocha --bail --exitreached 90 passing tests (including the new regression and existing__proto__coverage); it then hit an existing xhr timeout afternpm ci --ignore-scriptsleft the optional HTTP/3 native module unavailable on Windows.