Accept deployed Aptos write reply wire layout#126
Draft
cawthorne wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the Aptos SDK decoder accept both the currently deployed
WriteReportReplywire layout and the newer SDK layout.Why
The Aptos capability/plugin still emits the deployed layout, while the newer SDK expected reordered fields for
receiver_contract_execution_status. That broke downstream workflow decoding when we started asserting richer write reply semantics.What Changed
WriteReportReplydecoder to accept both layouts during rolloutValidation
cd capabilities/blockchain/aptos && go test ./... -count=1Notes