[WIP / RFC] Core cleanup - Move codecs into its own cciplib go mod#778
Draft
ogtownsend wants to merge 1 commit into
Draft
[WIP / RFC] Core cleanup - Move codecs into its own cciplib go mod#778ogtownsend wants to merge 1 commit into
ogtownsend wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
github.com/smartcontractkit/chainlink-ton/cciplibso consumers can import the codec without pulling all ofchainlink-ton.cciplib:ccip/codec,ccip/bindings/{common,ocr,feequoter,onramp,ownable2step},ton/{tvm,hash,parser,tlbe}, plus themocks/ccipocr3test mocks.cciplib/go.mod(leaf module:tonutils-go,chainlink-common,go-ethereum,samber/lo,golang.org/x/sync; test-onlysui-go-sdk,solana-go,chain-selectors) andcciplib/.mockery.yaml.chainlink-tonmain,deployment,integration-tests, andstaging-monitormodules to the newcciplibpaths.chainlink-tonmodule tocciplibviarequire+ intra-reporeplace(mirroring the existingdeploymentsubmodule pattern)..mockery.yaml(its only entry moved tocciplib).Cross-repo changes (separate PRs)
mcms: repointssdk/ton(+e2e/tests/ton) imports of the 5 moved packages tocciplib, sincemcmsis an external consumer of them: [WIP] use new cciplib from cl-ton mcms#807chainlink: swapscore/capabilities/ccip/ccipton/pluginconfig.goanddeployment/ccip/shared/stateview/state.gotocciplib, and dropschainlink-tonfrom the mainchainlink/go.modentirely (onlycciplibremains).Verified (via local
replace)cciplibbuilds and unit tests pass; confirmed clean leaf (no back-edge intochainlink-ton).chainlink-tonmain +deploymentmodules build and test-compile.mcms/sdk/tonbuilds and vets clean againstcciplib.chainlinkcorecciptonanddeploymentstateviewbuild;chainlink-tonno longer in core's main module graph.Blockers / not-yet-resolved
chainlink-ton/staging-monitorbuild is blocked by achainlink-deployments-frameworkStateProvider.GetAddressvariadic signature change dragged in by newermcms(unrelated to this move).chainlink-ton/integration-teststest-compile is blocked by the not-yet-publishedchainlinkstateviewchange plus a pre-existingchainlink-suiversion skew (unrelated to this move).go.mdandmodgraph/gomodsoutputs have not been regenerated (needs repo nix tooling) and will fail the "up to date" CI check.Next steps
replacedirectives and cannot build standalone until the dependency chain is published in order (mcms→chainlink-ton→chainlink). PublishmcmsPR, then bumpchainlink-tonto the releasedmcmsand remove the threemcms => ../../mcmsreplaces.cciplib, then bump thecciplibref inchainlinkcore and remove its temporaryreplaceinchainlink/go.modandchainlink/deployment/go.mod.staging-monitorGetAddressvariadic fix during version coordination.go.md/ runmodgraphbefore merging thechainlink-tonPR.