SK-3017-gitleaks-detection-multiple-secret-exposures-identified - #336
Merged
Conversation
…E/tests Adds .gitleaksignore with fingerprints for the 9 flagged generic-api-key findings — UUID-format sample/reveal tokens used in Skyflow/README.md's documentation code blocks and in RevealSkyflowLabelViewTests.swift, not real credentials. Note: the repo was restructured since the original scan (README.md split into Skyflow/README.md and SkyflowFlowVault/README.md; the test file moved under SkyflowFlowVault/Tests/). Fingerprints below target the current paths/line numbers on main for the same flagged values. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The org-wide Gitleaks scan flagged 9 generic-api-key findings — UUID-format sample/reveal tokens used in README.md's documentation code blocks and in a reveal-label test file. These are illustrative example values, not real credentials, but the findings need to be resolved to close out the security review.
Note: the repo was restructured since the original scan (README.md was split into
Skyflow/README.mdandSkyflowFlowVault/README.md; the test file moved underSkyflowFlowVault/Tests/). This PR's fingerprints target the current paths/line numbers onmainfor the same flagged values.Goal:
Suppress the false-positive findings without altering the visible README/test content, by adding a .gitleaksignore file with fingerprints for the specific findings — Gitleaks' native, built-in suppression mechanism for exactly this case.
Ref: same pattern as skyflow-react-native#157.
Jira: SK-3017
🤖 Generated with Claude Code