Fix Swift-syntax code examples in skyvault README - #198
Merged
saileshwar-skyflow merged 1 commit intoAug 26, 2026
Conversation
Convert Swift-style snippets to Kotlin: named-arg colons to `=`, `let` to `val`, and add the `context` arg to create() calls. Doc-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
skyflow-bharti
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the remaining Swift-syntax code examples in
skyvault/README.mdto Kotlin. Doc-only — no SDK/source changes, so skyvault stays byte-identical to 1.27.0. These were pre-existing (shipped with 1.27.0), ported from iOS docs with incomplete conversion.Changes (all in
skyvault/README.md, 34 lines)=in value examples:CollectElementOptions/RevealElementOptions(required:,enableCardIcon:,format:,translation:), the initOptionsblock,create()(input:,options:), and the set-log-level snippets (logLevel:).let→valon the two revealcreate()examples, plus added the requiredcontext = thisargument.SKyflow→Skyflowtypo in the init example.Prose method-signature descriptions (e.g. inline
create(context: Context, input: …)inside sentences) are a documentation convention and were left as-is.🤖 Generated with Claude Code