fix(fe): prevent contest delete modal from opening without selection#3635
fix(fe): prevent contest delete modal from opening without selection#3635jinukkkim wants to merge 1 commit into
Conversation
선택된 항목이 없을 때 휴지통 버튼을 누르면 모달이 강제로 열리는 버그를 수정한다. AlertModal의 트리거 버튼을 분리하여 모달 상태 제어를 독립시킨다.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the DataTableDeleteButton component by rendering the trigger button and the AlertModal side-by-side within a React Fragment, rather than passing the button as a trigger prop. The feedback suggests two improvements: adding an aria-label to the icon-only button to improve web accessibility (a11y), and replacing the object spreading pattern for the conditional description prop with a cleaner ternary operator to enhance readability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
4 participants
Description
어드민 페이지의 데이터 테이블에서, 선택된 항목이 없을 때 휴지통 버튼을 누르면 에러 토스트( Please select at least one... )와 함께 삭제 경고 모달 창이 동시에 강제로 열려버리는 버그를 수정했습니다.
Additional context
Before submitting the PR, please make sure you do the following
fixes #123).Closes TAS-2759