feat(fe): impl verification logic for whitelist removal by ojongii · Pull Request #3552 · skkuding/codedang

ojongii · 2026-05-09T13:57:56Z

Description

아이디 중복 확인, 이메일 인증, 닉네임 자동 생성, 직업 드롭다운, 대학교 검색 기능을 구현했습니다. 닉네임 중복 확인은 백엔드 API가 없어서 아직 구현하지 못했어요.

성균관대학교 선택 시 이메일 도메인이 @skku.edu로 고정되고 학과 검색과 학번 입력 필드가 추가됩니다. 그 외 대학교는 자유 이메일 입력이고 학과, 학번 항목은 표시되지 않습니다.

Additional context

closes TAS-2691

Before submitting the PR, please make sure you do the following

Read the Contributing Guidelines
Read the Contributing Guidelines and follow the Commit Convention
Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
Ideally, include relevant tests that fail without this PR but pass with it.

gemini-code-assist

Code Review

This pull request significantly expands the SignUpPage component, introducing features such as user ID and nickname availability checks, email verification with a timer, and dynamic selection for jobs, universities, and majors. It also integrates the korea-universities library and adds SKKU-specific registration logic. Feedback highlights a mismatch between password validation regex and its associated messages, suggests using the json option in API calls for consistency, and recommends adding error handling to the onSubmit function to improve the user experience.

skkuding-bot · 2026-05-09T14:01:27Z

✅ Syncing Preview App Succeeded

Application: frontend
Revision: 090e50eb14d6c5a1f9a2d813a976f774df159456
Health Status: Healthy

Open Preview | View in Argo CD

skkuding-bot · 2026-05-09T23:57:43Z

✅ Syncing Preview App Succeeded

Application: frontend
Revision: adba6cd149efc7128b0e9379ca1e8566121ea2cc
Health Status: Healthy

Open Preview | View in Argo CD

skkuding-bot · 2026-05-11T11:54:50Z

✅ Syncing Preview App Succeeded

Application: frontend
Revision: f6a03cb7e368eefcb254e24e629d3a0879fd6870
Health Status: Healthy

Open Preview | View in Argo CD

dayeoni · 2026-05-13T05:42:42Z

+                <div className="relative flex-1">
+                  <input
+                    type="text"
+                    placeholder="신나는 청사과"


기본 닉네임은 제가 임의로 작성했던거라, 우아한 형제들이 제공하는 기능을 활용하면 닉네임 placeholder를 그 중 하나로 변경하면 될거 같습니다!

위 댓글 참고 부탁드립니다!

dayeoni · 2026-05-13T05:54:20Z

[화면 기반 수정사항입니다!]

아이디에 값 입력 후 중복 확인버튼을 누르면, '아이디 중복 확인을 해주세요'가 1초 나온 다음, '사용 가능한 아이디입니다'가 나옵니다!
다른 입력란은 입력->검증 완료 후 border가 사라지는데, 아이디는 중복 확인 이후에도 border가 유지됩니다. 사라지도록 수정부탁드립니다!

skkuding-bot · 2026-05-13T19:51:56Z

❗ Syncing Preview App Failed

Application: frontend
Revision: t2691-impl-verification-logic-for-whitelist-removal
Health Status: Healthy

Open Preview | View in Argo CD

nhjbest22 · 2026-05-15T02:20:17Z

main이 아니라 feat/remove-whitelist로 올려주세요!

skkuding-bot · 2026-05-20T06:41:39Z

✅ Syncing Preview App Succeeded

Application: frontend
Revision: a8880dbfb425fffcece6489b70e94c4ec9f2b7bd
Health Status: Healthy

Open Preview | View in Argo CD

skkuding-bot · 2026-05-23T02:11:20Z

✅ Syncing Preview App Succeeded

Application: frontend
Revision: d62f04eff3e092167e9caadc39433b22a0057093
Health Status: Healthy

Open Preview | View in Argo CD

ojongii · 2026-05-27T09:29:04Z

korean-random-names-generator 닉네임 생성 패키지를 설치하고 placeholder를 변경했습니다.

아래는 지난 회의 노션에 기록된 기획 관련 수정 사항입니다.

일반인도 이메일 인증하기 -> 백엔드 구현이 안 된 상태여서 아직 작업하지 않았습니다.
닉네임은 중복확인 X (고유식별자는 ID, 이메일) -> 중복 확인 버튼 제거하고 관련 프론트 코드 모두 제거했습니다.
생년월일 제거 -> 지난 커밋에서 UI 제거했고, 이번 커밋에서 관련 필드를 스키마에서 제거했습니다.
프로필 생성시, 코드당 캐릭터 안하고, 저번 api랑 프로필 업로드 두개로 진행하기로~ -> 작업 범위와 무관
아이디 기입 시, 공백이나 특수문자(언더바 외)는 사용할 수 없습니다. (→ 중복확인 할 때 아래 빨간색으로 표시) -> 먼저 백엔드에서 언더바가 허용되도록 바뀌어야 할 것 같아서 아직 작업하지 않았습니다!
(선택) 마케팅 활용 동의 및 광고 수신 동의 제거 -> 체크박스 UI 제거했습니다!

skkuding-bot · 2026-05-27T09:41:55Z

❗ Syncing Preview App Failed

Application: frontend
Revision: 217299cd9e122f339707657a82ded965cfe450b6
Health Status: Degraded

Open Preview | View in Argo CD

skkuding-bot · 2026-06-20T23:33:34Z

✅ Syncing Preview App Succeeded

Application: frontend
Revision: 707322599e374314d24aa2dc13b48c1f2465e599
Health Status: Healthy

Open Preview | View in Argo CD

ojongii · 2026-07-03T13:23:41Z

main이 아니라 feat/remove-whitelist로 올려주세요!

@nhjbest22 stage 백엔드가 아직 main 기준으로 배포되어 구버전 코드가 실행 중이어서 Preview 페이지와 로컬 환경에서 외부 이메일로 전송이 실패하고 있습니다. 프론트엔드 테스트 목적으로 해당 백엔드 PR만이라도 먼저 main에 머지하는 게 가능할까요?

skkuding-bot · 2026-07-05T06:48:45Z

✅ Syncing Preview App Succeeded

Application: frontend
Revision: 59c73ef37cfa16c0ade7998f03873d63ef5dc9ec
Health Status: Healthy

Open Preview | View in Argo CD

skkuding-bot · 2026-07-06T03:38:11Z

✅ Syncing Preview App Succeeded

Application: frontend
Revision: f308a97a809add82a6b725a56eb9b29a15562fef
Health Status: Healthy

Open Preview | View in Argo CD

…lick handling

skkuding-bot · 2026-07-06T03:51:53Z

✅ Syncing Preview App Succeeded

Application: frontend
Revision: 643e37f2d47f68503ffe9a7abcbe29b3c56a9e9f
Health Status: Healthy

Open Preview | View in Argo CD

skkuding-bot · 2026-07-07T04:27:59Z

✅ Syncing Preview App Succeeded

Application: frontend
Revision: 2f45fad793d22916bf1ba4e4ffc96976de258d57
Health Status: Healthy

Open Preview | View in Argo CD

skkuding-bot · 2026-07-16T05:04:58Z

✅ Syncing Preview App Succeeded

Application: frontend
Revision: 7e7239741c3189f695a50dec252b4c842d803db8
Health Status: Healthy

Open Preview | View in Argo CD

skkuding-bot · 2026-07-16T05:13:36Z

✅ Syncing Preview App Succeeded

Application: frontend
Revision: e194c1b5fd5c4f618e1046199ed59c07b4ea681c
Health Status: Healthy

Open Preview | View in Argo CD

ojongii requested a review from dayeoni May 9, 2026 13:57

ojongii self-assigned this May 9, 2026

ojongii added ⛳️ team-frontend preview 이 라벨이 붙어있어야 프론트엔드 Preview 환경이 생성됩니다 labels May 9, 2026

gemini-code-assist Bot reviewed May 9, 2026

View reviewed changes

Comment thread apps/frontend/components/auth/SignUpPage/signup.schema.ts Outdated

Comment thread apps/frontend/components/auth/SignUpPage/SignUpPage.tsx

Comment thread apps/frontend/components/auth/SignUpPage/SignUpPage.tsx Outdated

dayeoni reviewed May 13, 2026

View reviewed changes

Comment thread apps/frontend/components/auth/SignUpPage/SignUpPage.tsx

ojongii changed the base branch from main to feat/remove-whitelist May 20, 2026 06:08

ojongii and others added 8 commits June 21, 2026 08:23

feat(fe): impl verification logic for whitelist removal

6f1f420

fix(fe): add studentId field, remove comments, and fix error message

fd37c8a

fix(fe): apply feedback

aac8219

fix(fe): cleanup code and refine design

c170454

fix(fe): update signup form fields and UI

29a0a44

chore(fe): fix email input overflow in signup form

1bf753b

fix(fe): apply changes and feedback

8afe637

feat(fe): redesign signup page and connect nickname/jobType to API

c7d2420

fix(fe): show update information modal only for SKKU students

f308a97

ojongii force-pushed the t2691-impl-verification-logic-for-whitelist-removal branch from 59c73ef to f308a97 Compare July 6, 2026 03:37

refactor(fe): replace job dropdown with Select and simplify outside-c…

643e37f

…lick handling

fix(fe): fix transparent selectcontent and refactor signup dropdowns

2f45fad

fix(fe): center CODEDANG logo horizontally in signup page

7e72397

refactor(fe): extract shared university and major search components

e194c1b

Uh oh!

Conversation

ojongii commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Additional context

Before submitting the PR, please make sure you do the following

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skkuding-bot Bot commented May 9, 2026

Uh oh!

skkuding-bot Bot commented May 9, 2026

Uh oh!

skkuding-bot Bot commented May 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dayeoni May 13, 2026

Choose a reason for hiding this comment

Uh oh!

ojongii May 22, 2026

Choose a reason for hiding this comment

Uh oh!

dayeoni commented May 13, 2026

Uh oh!

Uh oh!

skkuding-bot Bot commented May 13, 2026

Uh oh!

nhjbest22 commented May 15, 2026

Uh oh!

skkuding-bot Bot commented May 20, 2026

Uh oh!

skkuding-bot Bot commented May 23, 2026

Uh oh!

ojongii commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skkuding-bot Bot commented May 27, 2026

Uh oh!

skkuding-bot Bot commented Jun 20, 2026

Uh oh!

ojongii commented Jul 3, 2026

Uh oh!

skkuding-bot Bot commented Jul 5, 2026

Uh oh!

skkuding-bot Bot commented Jul 6, 2026

Uh oh!

skkuding-bot Bot commented Jul 6, 2026

Uh oh!

skkuding-bot Bot commented Jul 7, 2026

Uh oh!

skkuding-bot Bot commented Jul 16, 2026

Uh oh!

skkuding-bot Bot commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ojongii commented May 9, 2026 •

edited

Loading

ojongii commented May 27, 2026 •

edited

Loading