Fix crash when long-pressing text after removing a link #2271 - #2766
Open
AzazelSensei wants to merge 1 commit into
Open
Fix crash when long-pressing text after removing a link #2271#2766AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Dispose the leftover link recognizer so a second long-press does not hit a null link attribute. Fixes singerdmx#2271
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Long-pressing a link, choosing remove, then long-pressing the same text crashed on a null check of the link attribute. The gesture recognizer stayed cached after the link was gone.
I dispose that recognizer when the link is removed and skip the bang if the attribute is already missing.
Related Issues
Type of Change