fix: selection toolbar/handles track scroll viewport like TextField - #2762
Open
RekanDev wants to merge 2 commits into
Open
fix: selection toolbar/handles track scroll viewport like TextField#2762RekanDev wants to merge 2 commits into
RekanDev wants to merge 2 commits into
Conversation
Use the scroll viewport for selection-handle visibility instead of the full document size, clamp context-menu anchors into the visible region, and hide the Cut/Copy/Paste menu while scrolling — restoring it only when the selection is on-screen again (including after scrolling away and back). Co-authored-by: Cursor <cursoragent@cursor.com>
TextField restores Cut/Copy/Paste when a handle drag ends; Quill only cleared the magnifier offset. Recreate or rebuild the toolbar when handles settle so adjusting anchors always brings the menu back. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextField/RenderEditable.TextSelectionOverlaybehavior.Test plan
QuillEditor, verify Cut/Copy/Paste appearsTextFieldfor similar feelMade with Cursor