Skip to content

Fix: validate retry.afterStatusCodes is an array #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JSap0914 wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

Fix: validate retry.afterStatusCodes is an array #868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/utils/normalize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ export const normalizeRetryOptions = (retry: number | RetryOptions = {}): Intern
throw new Error('retry.statusCodes must be an array');
}

if (retry.afterStatusCodes && !Array.isArray(retry.afterStatusCodes)) {
throw new Error('retry.afterStatusCodes must be an array');
}

const normalizedRetry = Object.fromEntries(Object.entries({
...retry,
methods: retry.methods?.map(method => method.toLowerCase()),
Expand Down
13 changes: 13 additions & 0 deletions test/retry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,19 @@ test('throws when retry.statusCodes is not an array', async t => {
});
});

test('throws when retry.afterStatusCodes is not an array', async t => {
const server = await createHttpTestServer(t);

t.throws(() => {
void ky(server.url, {
retry: {
// @ts-expect-error
afterStatusCodes: 413,
},
});
});
});

test('retry options ignore undefined overrides and keep defaults', async t => {
let requestCount = 0;

Expand Down