Skip to content

添加 Connect 方法, 支持创建一个单独的连接 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hopehook wants to merge 4 commits into
base: master
Choose a base branch
from
Open

添加 Connect 方法, 支持创建一个单独的连接 #8

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe2f173
添加 Connect 方法, 支持创建一个单独的连接
achst Sep 22, 2018
5bb2e1d
Fix: Connect Close 方法做严格的检查，避免 Release 之后误操作
achst Sep 24, 2018
4d69fc6
BugFix: Connect参数返回缺失 && Release 把 ping 置为 nil && Ping 添加 nil 判断
achst Sep 30, 2018
96e6924
Feat: 修改注释
achst Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions channel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,16 +110,20 @@ func (c *channelPool) Get() (interface{}, error) {
}
return wrapConn.conn, nil
default:
conn, err := c.factory()
if err != nil {
return nil, err
}

return conn, nil
return c.Connect()
}
}
}

//Conn 重新创建一个连接

@silenceper silenceper Sep 23, 2018 •
edited
Loading

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golint: Connect

func (c *channelPool) Connect() (interface{}, error) {
conn, err := c.factory()
if err != nil {
return nil, err
}
return conn, nil
}

//Put 将连接放回pool中
func (c *channelPool) Put(conn interface{}) error {
if conn == nil {
Expand Down
2 changes: 2 additions & 0 deletions pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ var (
type Pool interface {
Get() (interface{}, error)

Connect() (interface{}, error)

Put(interface{}) error

Close(interface{}) error
Expand Down