Skip to content

Mark required method keys on four SWML reference pages - #593

Merged
hey-august merged 3 commits into
mainfrom
august-20260814-swml-required-flags
Aug 19, 2026
Merged

Mark required method keys on four SWML reference pages#593
hey-august merged 3 commits into
mainfrom
august-20260814-swml-required-flags

Conversation

@hey-august

Copy link
Copy Markdown
Collaborator

Description

This was a fix that came up during my review of #361, but didn't make it in before we merged that PR.

The SWML schema declares every method key as required. SWMLObject.json lists required: ["answer"], ["stop_stream"], ["transcribe"], and ["transcribe_stop"], matching the ?-free declarations in the TypeSpec
sources under specs/swml/calling/Methods/.

These four reference pages rendered the top-level ParamField without required={true}, so the method key incorrectly appeared to be optional.

A sweep of all 113 schema-required top-level keys against the SWML reference found these four pages and no others. One line changes on each; yarn fern-md-check passes.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Code cleanup / refactor

Related Issues

Testing

  • Added/updated unit tests
  • Tested manually
  • Tested with live SignalWire credentials (if applicable)

Checklist

  • I have read the CONTRIBUTING guidelines
  • My code follows the project's style guidelines
  • I have added tests for my changes (if applicable)
  • I have updated documentation (if applicable)
  • All existing tests pass

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@hey-august
hey-august merged commit 20fd5a3 into main Aug 19, 2026
2 checks passed
@hey-august
hey-august deleted the august-20260814-swml-required-flags branch August 19, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants