field_identifier and variant_identifier container attributes - #107
Open
tobz1000 wants to merge 1 commit into
Open
field_identifier and variant_identifier container attributes#107tobz1000 wants to merge 1 commit into
field_identifier and variant_identifier container attributes#107tobz1000 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These sections are taken from PR #96, where they were initially rejected, because they are not particularly useful for automatic derive.
I'm submitting them again for consideration, for a few reasons:
field_identifierwithout understanding its purpose. Putting aside whether this should be done, it would be helpful for people who come across it during experimentation to understand it.field_identifieris mentioned in that crate's docs. This is where I found myself in need of a quick refresher on what this attribute actually does.I also had a quick look at the history of
serde_derive/.../attr.rs, and it seems like there are no other undocumented attributes to add at the moment.