Add mDNS ICE fallback and configurable H264 media support - #284
Open
maikebing wants to merge 5 commits into
Open
Add mDNS ICE fallback and configurable H264 media support#284maikebing wants to merge 5 commits into
maikebing wants to merge 5 commits into
Conversation
maikebing
force-pushed
the
codex/laneapp-upstream
branch
from
August 24, 2026 03:43
638addc to
87dd449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves WebRTC interoperability for browser-generated offers and adds configurable H264/media behavior required by server-side streaming applications.
The changes are split into four focused commits:
Motivation
Browsers commonly advertise host candidates using
.localmDNS names. When the server cannot resolve such a name, rejecting the candidate aborts ICE before an authenticated STUN request can reveal the peer-reflexive address.This PR retains an unresolved mDNS candidate as
0.0.0.0with its original port. A subsequent authenticated Binding request containingUSE-CANDIDATEcan then update the nominated pair with the observed source address.This preserves browser privacy behavior and does not require disabling mDNS candidate obfuscation.
Changes
mDNS and ICE
.localhostnames by suffixUSE-CANDIDATEattributeMedia port ranges
port_range_beginandport_range_endconfigurationH264 SDP configuration
H264 RTP packetization
peer_connection_send_video_at()for explicit 90 kHz RTP timestampsCompatibility
Tests
Added targeted tests for:
.localcandidatesUSE-CANDIDATEVerification results:
libpeer.aarchive build: passed