Skip to content

Fix RTP header wire serialization - #267

Closed
Pie8851 wants to merge 2 commits into
sepfy:mainfrom
Pie8851:fix/rtp-header-wire-format
Closed

Fix RTP header wire serialization#267
Pie8851 wants to merge 2 commits into
sepfy:mainfrom
Pie8851:fix/rtp-header-wire-format

Conversation

@Pie8851

@Pie8851 Pie8851 commented Aug 1, 2026

Copy link
Copy Markdown

Summary

  • serialize RTP fixed-header bytes explicitly instead of relying on C bitfield layout
  • preserve RTP v2, payload type, marker, sequence, timestamp, and SSRC semantics across host architectures

Test plan

  • Build the repository integration with tools/ci/native_build_test.sh libs/libpeer
  • Build Desktop Tiga with bazel build --config=macos_arm64 //projects/desktop/apps/h106/tiga:h106-tiga
  • Verify a macOS Opus packet starts with 80 6f after the change

Made with Cursor

Pie8851 and others added 2 commits August 1, 2026 22:11
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Pie8851

Pie8851 commented Aug 2, 2026

Copy link
Copy Markdown
Author

Closing this in favor of #269, which provides the smaller targeted fix for the confirmed macOS root cause: Apple headers expose BYTE_ORDER/BIG_ENDIAN/LITTLE_ENDIAN, while the existing selector checks their underscored names.

The explicit RTP serialization here avoids bit-field layout dependence, but it is broader than needed for the currently confirmed issue. #269 preserves the existing layout and corrects the macOS endian-macro mapping.

@Pie8851 Pie8851 closed this Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant