Add workflow to run SDGym monthly and publish results - #427
Merged
Conversation
Contributor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 70.97% 71.79% +0.81%
==========================================
Files 24 27 +3
Lines 1840 2088 +248
==========================================
+ Hits 1306 1499 +193
- Misses 534 589 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
R-Palazzo
commented
Jul 24, 2025
amontanez24
reviewed
Jul 29, 2025
R-Palazzo
force-pushed
the
issue-425-workflow-sdgym
branch
from
August 4, 2025 13:46
e928db0 to
e63a58d
Compare
R-Palazzo
commented
Aug 5, 2025
R-Palazzo
commented
Aug 5, 2025
| from sdgym.s3 import parse_s3_path | ||
|
|
||
| OUTPUT_DESTINATION_AWS = 's3://sdgym-benchmark/Benchmarks/' | ||
| UPLOAD_DESTINATION_AWS = 's3://sdgym-benchmark/Benchmarks/' |
Collaborator
Author
There was a problem hiding this comment.
Along with the Github location, I'm also uploading the summary there so we have a backup.
amontanez24
reviewed
Aug 8, 2025
R-Palazzo
force-pushed
the
issue-425-workflow-sdgym
branch
from
August 25, 2025 10:22
7eb91af to
fc7321b
Compare
R-Palazzo
commented
Aug 25, 2025
R-Palazzo
force-pushed
the
issue-425-workflow-sdgym
branch
from
August 25, 2025 14:34
c1c2830 to
3791993
Compare
amontanez24
reviewed
Aug 27, 2025
amontanez24
left a comment
amontanez24
left a comment
Contributor
There was a problem hiding this comment.
Looking really good! Should e the last round of comments
| --base gatsby-home \ | ||
| --title "Upload SDGym Benchmark Results ($FOLDER_NAME)" \ | ||
| --body "Automated benchmark results upload" \ | ||
| --reviewer "amontanez24" |
Contributor
There was a problem hiding this comment.
you can remove this before merging
Comment on lines
+60
to
+62
| - name: Checkout target repo (sdv-dev.github.io) | ||
| if: env.SKIP_UPLOAD != 'true' | ||
| run: | | ||
| git clone https://github.com/sdv-dev/sdv-dev.github.io.git target-repo | ||
| cd target-repo | ||
| git checkout gatsby-home |
Contributor
There was a problem hiding this comment.
why don't we use the github checkout action for this?
Collaborator
Author
There was a problem hiding this comment.
Hi @amontanez24, I've reinstated the command to directly commit fb5b32a. Last time it was this commit:
sdv-dev/sdv-dev.github.io@0911425
amontanez24
approved these changes
Aug 27, 2025
This reverts commit a192435.
R-Palazzo
force-pushed
the
issue-425-workflow-sdgym
branch
from
August 27, 2025 18:20
3442f44 to
f23428c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CU-86b5qr8wj
Resolve #425