[WJ-1361] implement PageQueryService::select() with SelectedFields - #2819
Open
0x5267 wants to merge 4 commits into
Open
[WJ-1361] implement PageQueryService::select() with SelectedFields#28190x5267 wants to merge 4 commits into
0x5267 wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2819 +/- ##
===========================================
- Coverage 19.45% 19.25% -0.21%
===========================================
Files 191 191
Lines 12267 12324 +57
===========================================
- Hits 2387 2373 -14
- Misses 9880 9951 +71
🚀 New features to boost your workflow:
|
emmiegit
reviewed
Apr 5, 2026
emmiegit
force-pushed
the
wj-1361-page-query-select
branch
from
April 10, 2026 03:42
767a919 to
db2932c
Compare
emmiegit
reviewed
Apr 11, 2026
Bumps the npm_and_yarn group with 1 update in the /framerail directory: [@sveltejs/kit](https://github.com/sveltejs/kit/tree/HEAD/packages/kit). Updates `@sveltejs/kit` from 2.55.0 to 2.57.1 - [Release notes](https://github.com/sveltejs/kit/releases) - [Changelog](https://github.com/sveltejs/kit/blob/main/packages/kit/CHANGELOG.md) - [Commits](https://github.com/sveltejs/kit/commits/@sveltejs/kit@2.57.1/packages/kit) --- updated-dependencies: - dependency-name: "@sveltejs/kit" dependency-version: 2.57.1 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
emmiegit
reviewed
Apr 12, 2026
| None | ||
| }, | ||
| category: if fields.contains(SelectedField::Category) { | ||
| row.slug.as_deref().map(|s| get_category_name(s).to_owned()) |
Member
There was a problem hiding this comment.
This is closer, though I was saying I think we should also modify the struct type row uses to have full_slug, page_slug, and category, so here we're just moving the field instead of processing it.
(That is, this processing, e.g. get_category_name(), is done when building SelectedPageRow instead of here)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelectedFields,SelectedField,SelectedPageRow, andSelectedPagestypesPageQueryService::select()to extract requested fields fromFoundPagesscore_votes,revisions,comments,children,size) return null for now