docs(TextInput): audit accessibility - #6732
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6732 +/- ##
==========================================
+ Coverage 91.01% 91.07% +0.05%
==========================================
Files 560 560
Lines 10253 10253
Branches 3692 3692
==========================================
+ Hits 9332 9338 +6
+ Misses 921 915 -6 see 3 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
|
||
| **Medium:** | ||
|
|
||
| - Password visibility toggle buttons lack accessible labels that indicate the action. "show" and "hide" are ambiguous without context. Should be "Show password" and "Hide password", or use `tooltipLabel` prop. |
There was a problem hiding this comment.
I think the tooltipLabel prop should define the label of the field itself and not some subcomponents, right ? Maybe we could have a labels prop as an object with different labels used in the component. Same for the clear button below
Summary
Type
Summarize concisely:
What is expected?
Audit
TextInputaccessibility