feat: improve Modal/Dialog/Drawer animations - #6729
Conversation
🦋 Changeset detectedLatest commit: 37b2566 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
630dee1 to
f5141e0
Compare
039a6c8 to
8554e4e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6729 +/- ##
==========================================
- Coverage 91.06% 91.05% -0.01%
==========================================
Files 560 561 +1
Lines 10253 10276 +23
Branches 3692 3719 +27
==========================================
+ Hits 9337 9357 +20
- Misses 916 919 +3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
| */ | ||
| export const ANIMATION_DURATION = 250 | ||
| export const ANIMATION_EASING = 'cubic-bezier(0.5, 0, 0.2, 1)' | ||
| export const ANIMATION_EASING = 'cubic-bezier(0.5, 0, 0.1, 1)' |
There was a problem hiding this comment.
I updated the curve on the Navigation component to be the same as the Drawer, and the duration is the same too, so that we can mutualize them later in the animations package. I'm not doing it now because I don't really know in what format to export them (JS constant, vanilla extract variables, CSS variables...)
08f0dca to
d0fbaaf
Compare
Summary
Type
Summarize concisely:
What is expected?
Smooth opening/closing animations
The following changes were made: