Skip to content

fix(InfoTable): style and overflow - #6727

Merged
lisalupi merged 2 commits into
mainfrom
fix/infotable-cell
Jul 31, 2026
Merged

fix(InfoTable): style and overflow#6727
lisalupi merged 2 commits into
mainfrom
fix/infotable-cell

Conversation

@lisalupi

Copy link
Copy Markdown
Collaborator

Summary

Type

  • Bug
  • Enhancement

Summarize concisely:

What is expected?

InfoTable.Cell:

  • should not override the custom style of its children.
  • when children are an array of strings or numbers, the same style is applied as for a single string.

Text: updated tooltip detection logic to handle overflowing content when children are of type (string | number)[]. Such arrays are now converted to strings for tooltip display. For example:

<Text as="p" variant="body">Ready?{isReady ? "Yes!" : "No..."}</Text>

Previously, no tooltip appeared when overflowing since the computed child was ['Ready?', 'Yes!'] (or ['Ready?', 'No...']). Now, the tooltip correctly displays Ready? Yes!.

@lisalupi
lisalupi requested a review from philibea July 29, 2026 08:55
@lisalupi lisalupi self-assigned this Jul 29, 2026
@lisalupi
lisalupi requested a review from jsulpis as a code owner July 29, 2026 08:55
@lisalupi lisalupi added bug Something isn't working enhancement New feature or request labels Jul 29, 2026
@changeset-bot

changeset-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 550409e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.02%. Comparing base (0242868) to head (550409e).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6727   +/-   ##
=======================================
  Coverage   91.01%   91.02%           
=======================================
  Files         560      561    +1     
  Lines       10253    10260    +7     
  Branches     3692     3717   +25     
=======================================
+ Hits         9332     9339    +7     
  Misses        921      921           
Files with missing lines Coverage Δ
.../ui/src/compositions/InfoTable/components/Cell.tsx 100.00% <100.00%> (ø)
...ckages/ui/src/compositions/InfoTable/styles.css.ts 100.00% <ø> (ø)
packages/ui/src/helpers/isStringOrNumberArray.ts 100.00% <100.00%> (ø)
...ges/ui/src/helpers/recursivelyGetChildrenString.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0242868...550409e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/ui/src/helpers/recursivelyGetChildrenString.ts Outdated
Comment thread packages/ui/src/helpers/isStringNumberArray.ts Outdated
@lisalupi
lisalupi merged commit 0a49bf6 into main Jul 31, 2026
17 checks passed
@lisalupi
lisalupi deleted the fix/infotable-cell branch July 31, 2026 08:22
@github-actions github-actions Bot mentioned this pull request Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants