feat(use-field): add use field to textarea, timeinput - #6705
Open
philibea wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 3546d91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6705 +/- ##
==========================================
- Coverage 91.01% 91.00% -0.01%
==========================================
Files 560 560
Lines 10253 10233 -20
Branches 3692 3707 +15
==========================================
- Hits 9332 9313 -19
+ Misses 921 920 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
philibea
force-pushed
the
use-field-simple
branch
7 times, most recently
from
July 30, 2026 09:21
cade90d to
0db4bfc
Compare
philibea
commented
Jul 30, 2026
| * Classic prop type where label is a ReactNode and aria-label is a string. | ||
| * One or another is required. | ||
| */ | ||
| export type FormComponentProps = { |
Collaborator
Author
There was a problem hiding this comment.
should we add
* Display an error message under the select bar
*/
error?: string | boolean
philibea
force-pushed
the
use-field-simple
branch
5 times, most recently
from
July 30, 2026 14:05
206f4e0 to
87ba9e6
Compare
Signed-off-by: Alexandre Philibeaux <aphilibeaux@scaleway.com>
philibea
force-pushed
the
use-field-simple
branch
from
July 30, 2026 14:08
87ba9e6 to
3546d91
Compare
lisalupi
reviewed
Jul 31, 2026
| const DEFAULT_VALUE = new Date('01/01/2000 11:23:14') | ||
|
|
||
| describe('timeInput', () => { | ||
| it('renders correctly with base props', () => shouldMatchSnapshot(<TimeInput />)) |
| "@ultraviolet/form": patch | ||
| --- | ||
|
|
||
| use new useField hook to TimeInputField, TextAreaField which allow usage of the rhf register api" |
Collaborator
There was a problem hiding this comment.
Suggested change
| use new useField hook to TimeInputField, TextAreaField which allow usage of the rhf register api" | |
| use new useField hook to TimeInputField, TextAreaField which allow usage of the rhf register api |
+ I think it's missing a changeset for the changes you made in ultraviolet ui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarize concisely:
What is expected?
Migrate TextAreaField, TimeInputField with new hook: useField