Implement From<&[u8]> for binary - #757
Merged
Merged
Conversation
filmor
requested changes
Aug 23, 2026
hauleth
force-pushed
the
push-pmwzwkxtotru
branch
from
August 25, 2026 14:10
3616935 to
2ee48f8
Compare
filmor
requested changes
Aug 25, 2026
This allows for simpler work with binaries that aren't UTF-8 encoded strings. Currently there is either need to construct such data in place (which limits usage of some Rust libraries) or you need to write additional code to translate one form into another. This implementation is simple and performant enough for this usecase.
hauleth
force-pushed
the
push-pmwzwkxtotru
branch
from
August 25, 2026 17:48
2ee48f8 to
c44d546
Compare
hauleth
commented
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for simpler work with binaries that aren't UTF-8 encoded
strings. Currently there is either need to construct such data in place
(which limits usage of some Rust libraries) or you need to write
additional code to translate one form into another. This implementation
is simple and performant enough for this usecase.