Skip to content

Permalink-ify branch file links to SHA file links#2466

Open
Urgau wants to merge 1 commit into
rust-lang:masterfrom
Urgau:branch-links
Open

Permalink-ify branch file links to SHA file links#2466
Urgau wants to merge 1 commit into
rust-lang:masterfrom
Urgau:branch-links

Conversation

@Urgau

@Urgau Urgau commented Jul 24, 2026

Copy link
Copy Markdown
Member

This PR implements a canonicalization of branch name based GitHub file link.

So instead of having https://github.com/torvalds/linux/blob/master/include/uapi/linux/audit.h#L389-L451 this PR would automatically update the PR description to https://github.com/torvalds/linux/blob/248951ddc14de84de3910f9b13f51491a8cd91df/include/uapi/linux/audit.h#L389-L451, or output a warning when found in commit messages.

Implements the plan from #2465 (comment)

I re-used the [issue-links] config, but it feels similar enough and to avoid conflict if both wants to update the PR description.

Fixes #2465
cc @tgross35

@Urgau
Urgau requested a review from Kobzol July 24, 2026 20:02

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit niche, but ok :)

View changes since this review

Comment thread src/handlers/check_commits/branch_links.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect non-permalinks in commit messages

2 participants