Skip to content

Assign last reviewer if they can merge with community reviews#2463

Merged
Urgau merged 1 commit into
rust-lang:masterfrom
Urgau:assign-community-reviews-assign-last-official
Jul 14, 2026
Merged

Assign last reviewer if they can merge with community reviews#2463
Urgau merged 1 commit into
rust-lang:masterfrom
Urgau:assign-community-reviews-assign-last-official

Conversation

@Urgau

@Urgau Urgau commented Jul 14, 2026

Copy link
Copy Markdown
Member

This PR updates the community reviews logic to assign the last reviewer, intead of performing auto-assignment, if they can merge.

This is meant to address cases like this, where the last reviewer is a Cliipy reviewer but we still perform the automatic assignment (it's by pure chance that the same reviewer was automatically selected).

cc @samueltardieu

@Urgau
Urgau requested a review from Kobzol July 14, 2026 12:31

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, makes sense.

View changes since this review

Comment thread src/handlers/assign.rs
@Urgau
Urgau force-pushed the assign-community-reviews-assign-last-official branch from 28c9884 to 247a7f0 Compare July 14, 2026 13:42
@Urgau
Urgau enabled auto-merge July 14, 2026 13:43
@Urgau
Urgau added this pull request to the merge queue Jul 14, 2026
Merged via the queue into rust-lang:master with commit 3c11f50 Jul 14, 2026
3 checks passed
@Urgau
Urgau deleted the assign-community-reviews-assign-last-official branch July 14, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants