Allow glob matches for autolabels and rendered links

[tgross35]

Use the same logic that currently exists for mentions to match autolabel.trigger-files and render-links.{trigger-files, exclude-files}.

The first commit just moves things around, the rest is less noisy.

[Urgau]

Looks good to me. Left two nits.

View changes since this review

[Urgau]

Since this is adding glob patterns to other places, would you mind adding some validation for users in validate_config.rs, similar to this one:

triagebot/src/handlers/check_commits/validate_config.rs

Lines 71 to 90 in 6368d60

	// Error if one the mentions entry is not a valid glob.
	if let Some(mentions) = config.mentions {
	for (entry, MentionsEntryConfig { type_, .. }) in mentions.entries {
	if type_ == MentionsEntryType::Filename {
	if let Err(err) = globset::Glob::new(&entry) {
	return Ok(Some(format!(
	"Invalid `triagebot.toml`:\n\
	`[mentions.\"{entry}\"]` has an invalid glob syntax: {err}"
	)));
	}
	if entry.starts_with('/') {
	return Ok(Some(format!(
	"Invalid `triagebot.toml`:\n\
	`[mentions.\"{entry}\"]` has an invalid pattern: path must be relative (remove the `/` at the start)"
	)));
	}
	}
	}
	}

If you don't want to do it that's fine, just tell me.

[tgross35]

Ah I didn't know this existed, added a commit changing it. Added a commit changing this though I'm not quite sure how to test. (Feel free to just push if there's something I'm missing)

[Urgau]

Testing requires a setting up triagebot on a repo and sending a PR changing traigebot.toml. I will test it for you.

[Urgau]

Works as expected!

Mentions:

Autolabel:

Rendered link:

Details

[autolabel."test"]
trigger_files = [
    "inva{id"
]

[rendered-link]
trigger-files = ["inva{id"]
exclude-files = ["inva{iid"]

[mentions."inval{id"]
cc = ["Urgau"]

The only sub-optimal thing is that we only show one error at a time, but that's pre-existing.

[Urgau]

Looks good to me. Thanks for the change (and the improvements!).

View changes since this review

[tgross35]

Thanks!