fix: Prevent infinite loops when parsing items from cfg_select! arms - #7089
Merged
Conversation
jieyouxu
approved these changes
Sep 1, 2026
Member
There was a problem hiding this comment.
The change itself seems reasonable. I'm unsure on the formatting of
cfg_select! {
_ => {
{}
{}
}
}to
cfg_select! { _ => {{} {}}}That seems... a bit curious? Oh I see, that's the source formatting.
@rustbot author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Contributor
Author
|
Oh I see what's going on. The stable tests are failing because -cfg_select! {
- _ => {
- {}
- {}
- }
-}
+cfg_select! { _ => {{} {}}} |
Member
|
Ah right, yeah that'd make sense |
Before when we failed to parse an item we'd hit an infinite loop because we wouldn't advance the parser. Now we make sure to advance the parser before starting the next loop iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7088
Before when we failed to parse an item we'd hit an infinite loop because we wouldn't advance the parser. Now we make sure to advance the parser before starting the next loop iteration.