Skip to content

tests: Implement snapshot test suites for formatting errors#6960

Open
clubby789 wants to merge 1 commit into
rust-lang:mainfrom
clubby789:snapshot-tests
Open

tests: Implement snapshot test suites for formatting errors#6960
clubby789 wants to merge 1 commit into
rust-lang:mainfrom
clubby789:snapshot-tests

Conversation

@clubby789

Copy link
Copy Markdown
Contributor

Suggested in #6947
cc @ytmimi

@rustbot rustbot added the S-waiting-on-review Status: awaiting review from the assignee but also interested parties. label Jul 17, 2026
@ytmimi

ytmimi commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Thanks for working on this. I'm traveling at the moment but I will set some time aside next week to take a look and provide any feedback.

@ytmimi

ytmimi commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

I think it would be useful to update the Contributing.md to include details on how to update the snapshot tests if they need to change or if new snapshot tests need to be added in the futuer. Even if it's just linking out to the insta docs having something there would be useful.

@ytmimi

ytmimi commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: awaiting review from the assignee but also interested parties. labels Jul 21, 2026
@rustbot

rustbot commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants