Unimplement fmt::Debug for c_void - #160115
Open
Jules-Bertholet wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @Darksonn rustbot has assigned @Darksonn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
A-FFI
Member
|
@bors try |
Contributor
|
⌛ Trying commit 03942bc with merge 82b0460… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/30416422288 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 29, 2026
Unimplement `fmt::Debug` for `c_void`
This comment has been minimized.
This comment has been minimized.
Taking a shared reference to `c_void` is always wrong.
Jules-Bertholet
force-pushed
the
no-c-void-debug
branch
from
July 29, 2026 02:25
03942bc to
588c33e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking a shared reference to
c_voidis never correct, and this impl should never have been added.This is obviously a breaking change, so needs crater and FCP.
@rustbot label T-libs-api needs-fcp A-FFI
See also #159986, #159935