Rollup of 11 pull requests#159692
Closed
GuillaumeGomez wants to merge 33 commits into
Closed
Conversation
Previously LLBC's Linker implementation unconditionally added `--debug` to the linker invocation. This just became visible when 062ecd6 made LLBC no longer strip debug information unconditionally. Add the proper logic to LLBC's linker implementation to only invoke LLBC with `--debug` when debug-information should not be stripped.
There are two `early_exit` closures in `run_compiler` that ensure `abort_if_errors` is called on all the early exit paths. However, these early exit paths all occur in the closure passed to `interface::run_compiler`. And what does `interface::run_compiler` do after calling the passed-in closure? It calls `finish_diagnostic` (always) and then `abort_if_errors` (if the closure didn't panic). So we can drop the `early_exit` calls and get the same behaviour.
This blanket allow was hiding several unused imports and items in test-only code. It has been replaced with a number of narrower ensures.
…esleywiser Fix splat v0 mangling Tracking issue: rust-lang#153629 Typecheck considers a splatted and non-splatted function as distinct types, so mangling has to include splatting. If it doesn't, we get symbol clashes. See the ticket and the tests in this PR for details. Demangling PR: rust-lang/rustc-demangle#90 Demangling in rust-lang/rust PR: rust-lang#159202 @rustbot label +C-bug +F-splat +T-compiler +A-name-mangling Fixes rust-lang#158644 This PR was based on rust-lang#159202, so we waited for that PR to merge first, then rebased this one.
[rustdoc] Correctly handle output options with --show-coverage Fixes rust-lang#158929. The `-o` option was ignored with `--show-coverage`. This PR takes it into account and makes it closer to how these options are handled in the rest of rustdoc. Considering `calculate_doc_coverage` was never really a pass and that I needed `RenderOptions` (for the `-o` option), I moved it out of passes. r? @camelid
…, r=bjorn3 Remove `early_exit` closures Details in individual commits. r? @bjorn3
define a `Simd` type in `minicore` Saves a lot of repetition. r? jieyouxu
…r=aDotInTheVoid,GuillaumeGomez Add paths for linked associated items rustdoc-json emits intra-doc links to associated items using the associated item's id. For external associated items, that id is not present in `index`, and it was also missing from `paths`. This PR backfills missing `paths` summaries for intra-doc link targets from the resolved page item and cached parent paths. Local targets are only added when already present in `index`, preserving jsondoclint's local-path invariant. Fixes rust-lang#152511
…rcote Fix debuginfo argument when invoking LLBC linker Previously LLBC's Linker implementation unconditionally added `--debug` to the linker invocation. This just became visible when 062ecd6 made LLBC no longer strip debug information unconditionally. It is also common to use `cargo build --release` together with `-Zbuild-std=core` when targeting NVPTX. In this case the release profile will prevent all crates from embedding debug information in the first place. This additionally made the bug less visible. This PR adds the proper logic to LLBC's linker implementation to only invoke LLBC with `--debug` when debug-information should not be stripped. I did not add a regression test yet, since this would require to actually invoke the linker in `assembly-llvm`. As soon as rust-lang#157512 is merged and we have `assembly-output: linker-asm` available, I want to follow up on that. cc: @kjetilkjeka @rustbot label +O-NVPTX
…up, r=GuillaumeGomez Bring runtime symbols statics on par with foreign functions This PR cleanups the `static` items path when checking the runtime symbols, and brings it on par with the foreign functions check. It also fixes a bug where static only reported the invalid lint and never the suspicious lint. Best reviewed commit by commit.
…r, r=RalfJung Refactor is_opsem_inhabited Refactor of rust-lang#156977 Introduce a struct to generally simplify the recursion. r? WaffleLapkin cc @RalfJung
…rop-oom, r=Darksonn Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit` Fixes rust-lang#159651
Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap - Originally added by rust-lang#138704 --- This blanket allow was hiding several unused imports and items in test-only code. It has been replaced with a number of narrower ensures. We can also drop the `pretty_assertions` dev-dependency, which turns out to have been unused.
…t-cycle-hang-test, r=lqd Add layout cycle hang regression test Fixes rust-lang#153205 The issue was already fixed rust-lang#153205 (comment)
rustbot
added
A-run-make
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
early_exitclosures #159647 (Removeearly_exitclosures)Simdtype inminicore#159656 (define aSimdtype inminicore)cfg(not(no_global_oom_handling))from theDropimpl ofUniqueArcUninit#159652 (Removecfg(not(no_global_oom_handling))from theDropimpl ofUniqueArcUninit)#![cfg_attr(test, allow(unused))]from bootstrap #159657 (Remove the blanket#![cfg_attr(test, allow(unused))]from bootstrap )r? @ghost
Create a similar rollup