Rollup of 18 pull requests#159610
Merged
Merged
Conversation
…onstant-sized We used to set a `slice: None`.
The InvocationStrategy::Once path indexed world.flycheck[0] directly. The always!() above only logs in release builds, so when the list was empty it fell through and panicked with index out of bounds. Use first() and skip the restart when there is no handle. Fixes rust-lang/rust-analyzer#21638
Previously, the soundness argument for the `pin!()` macro relied on very complicated conditions on what coercions are possible. As a result, it was not obvious whether the macro was sound or not, and the macro was potentially fragile to changes in how coercions work. Therefore, we change the `pin!()` macro so that it relies on less subtle properties of coercions. In particular: * The soundness argument now only relies on enumerating the possible types that a coercion could produce, as opposed to relying on details about how coercion expectations are propagated. * The soundness argument now only requires reasoning about possible coercions between a single pair of types defined in the standard library, as opposed to reasoning about two pairs of types, with some involved types being defined by the user. Fixes <rust-lang#153438>
Previously we would still try to rename the incr comp session dir after deleting it.
In both cases the incr comp session dir should no longer be accessed.
They should skip non-module scope (although I think they cannot skip and will do just fine), but must also process block module scopes.
Ask for disclosure in AI contributions
internal: update links to `rustc_hir_analysis`
fix: Resolve non-plain paths in blocks correctly
…tpluxqp feat: Treat library files as truly client immutable
… claude lifetime bound scope
…ztynowk internal: Split out a session construct
feat: early late classification of lifetimes
…=Kobzol Clarify `push_stream`/`push_tree` More `TokenStream` cleanups. Details in individual commits. r? @Kobzol
rustbot
added
A-attributes
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 20, 2026
Rollup of 18 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-* try-job: aarch64-apple-macos-26
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Jul 20, 2026
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d527bc9 (parent) -> 87e5904 (this PR) Test differencesShow 181 test diffsStage 0
Stage 1
Stage 2
(and 23 additional test diffs) Additionally, 58 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 87e5904f5eb6398af6b22eac2802c78934260c48 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: d527bc9bfa In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (87e5904): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.8%, secondary -2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.7%, secondary 4.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 489.235s -> 486.983s (-0.46%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rust-analyzersubtree update #159600 (rust-analyzersubtree update)AttrItem::span#159587 (ImproveAttrItem::span)impl Fnreturn for capturing closures #159594 (feat(rustc_hir_typeck): suggestimpl Fnreturn for capturing closures)arc4random_buffrom libc #159597 (std: usearc4random_buffrom libc)pin!()more foolproof. #158061 (Makepin!()more foolproof.)collect_tokens#159529 (Add regression test for nested replacement ranges incollect_tokens)TokenStreamimprovements #159585 (MinorTokenStreamimprovements)InterpCxusage byConstAnalysisphases #159586 (SeparateInterpCxusage byConstAnalysisphases)ItemLike#159602 (RemoveItemLike)push_stream/push_tree#159603 (Clarifypush_stream/push_tree)Failed merges:
r? @ghost
Create a similar rollup