Skip to content

Consider () as suspicious only when expecting ! for runtime symbols#159513

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Urgau:runtime-symbols-159446
Jul 23, 2026
Merged

Consider () as suspicious only when expecting ! for runtime symbols#159513
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Urgau:runtime-symbols-159446

Conversation

@Urgau

@Urgau Urgau commented Jul 18, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Consider () as suspicious only when expecting ! for runtime symbols, as ! is considered ABI compatible in Rust with () (#159446 (comment)).

Fixes #159446

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 18, 2026
@rustbot

rustbot commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 74 candidates
  • Random selection from 16 candidates

@Urgau Urgau mentioned this pull request Jul 18, 2026
Closed
fee1-dead
fee1-dead requested changes Jul 22, 2026
View reviewed changes

@fee1-dead fee1-dead left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after

View changes since this review

Comment thread compiler/rustc_lint/src/runtime_symbols.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@Urgau
Urgau force-pushed the runtime-symbols-159446 branch from ce1f705 to b1f030a Compare July 22, 2026 17:28
@rustbot

This comment has been minimized.

Sign in to view
@Urgau

Urgau commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

@bors r=fee1-dead

@rust-bors

rust-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b1f030a has been approved by fee1-dead

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2026
@Urgau

Urgau commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

@bors rollup

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#159513 - Urgau:runtime-symbols-159446, r=fe…
d5d4795 
…e1-dead

Consider `()` as suspicious only when expecting `!` for runtime symbols

Consider `()` as suspicious only when expecting `!` for runtime symbols, as `!` is considered ABI compatible in Rust with `()` (rust-lang#159446 (comment)).

Fixes rust-lang#159446
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 22, 2026
Closed
@JonathanBrouwer

JonathanBrouwer commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #159741 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2026
@rust-bors

rust-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#159741), which was unapproved.

View changes since this unapproval

@Urgau
Urgau force-pushed the runtime-symbols-159446 branch from b1f030a to 970a689 Compare July 22, 2026 21:43
@rustbot

rustbot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Urgau

Urgau commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

Fixed a small conflict with the stabilization of c-variadics (#155697).

@bors r=fee1-dead

@rust-bors

rust-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 970a689 has been approved by fee1-dead

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2026
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 22, 2026
@GuillaumeGomez
Rollup merge of rust-lang#159513 - Urgau:runtime-symbols-159446, r=fe…
90bdb1a 
…e1-dead

Consider `()` as suspicious only when expecting `!` for runtime symbols

Consider `()` as suspicious only when expecting `!` for runtime symbols, as `!` is considered ABI compatible in Rust with `()` (rust-lang#159446 (comment)).

Fixes rust-lang#159446
This was referenced Jul 22, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Jul 23, 2026
@bors
Auto merge of #159748 - GuillaumeGomez:rollup-9nyJVea, r=GuillaumeGomez
390279b 
Rollup of 8 pull requests

Successful merges:

 - #159504 (Abort const-eval queries early when there are generics in the type)
 - #159523 (std: fix Xous UDP recv length over-report and OOB panic)
 - #159605 (Add fallback for `intrinsics::fabs`)
 - #159699 (bump std libc to 0.2.189)
 - #159306 (Add new variant to iterating-updating-mutref borrowck test)
 - #159346 (fs::hard_link: use linkat on Android)
 - #159513 (Consider `()` as suspicious only when expecting `!` for runtime symbols)
 - #159734 (Document the link_section attribute)
@rust-bors
rust-bors Bot merged commit 4739758 into rust-lang:main Jul 23, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 23, 2026
rust-timer added a commit that referenced this pull request Jul 23, 2026
@rust-timer
Unrolled build for #159513
92044e9 
Rollup merge of #159513 - Urgau:runtime-symbols-159446, r=fee1-dead

Consider `()` as suspicious only when expecting `!` for runtime symbols

Consider `()` as suspicious only when expecting `!` for runtime symbols, as `!` is considered ABI compatible in Rust with `()` (#159446 (comment)).

Fixes #159446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fee1-dead fee1-dead fee1-dead requested changes

Assignees

@fee1-dead fee1-dead

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

Potential false positive for invalid_runtime_symbol_definitions lint

4 participants

@Urgau @rustbot @JonathanBrouwer @fee1-dead