Skip to content

Rollup of 3 pull requests#159367

Merged
rust-bors[bot] merged 6 commits into
rust-lang:mainfrom
jhpratt:rollup-m6CJJYQ
Jul 16, 2026
Merged

Rollup of 3 pull requests#159367
rust-bors[bot] merged 6 commits into
rust-lang:mainfrom
jhpratt:rollup-m6CJJYQ

Conversation

@jhpratt

@jhpratt jhpratt commented Jul 16, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

PiJoules and others added 6 commits July 9, 2026 17:31
…kingjubilee

fuchsia: Ensure all existing ported sanitizers for Fuchsia are supported
…tions, r=petrochenkov

Resolver: extract `use_injections` out of main `Resolver`

Prep work for rust-lang#158845. Extract the `use_injections` field out of the resolver and into the `LateResolutionVisitor`. It can then be passed into the `report_errors` pass, so no behaviour is changed.

This allows the `Resolver` to be `DynSync`, see rust-lang#158845 (comment).

r? @petrochenkov
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Jul 16, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 16, 2026
@jhpratt

jhpratt commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=5

@rust-bors

rust-bors Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 83dae99 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 16, 2026
@rust-bors

rust-bors Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 33m 13s
Pushing d62fb1c to main...

@rust-bors
rust-bors Bot merged commit d62fb1c into rust-lang:main Jul 16, 2026
14 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 16, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#159028 fuchsia: Ensure all existing ported sanitizers for Fuchsia … 4e0dc7f73cb05016b52bc17c4c3c6fa93edfe1cd (link)
#159339 Resolver: extract use_injections out of main Resolver 2959eef3f7390bf4e75d204da841d70dde2016b8 (link)
#159342 renovate: group github actions updates 8154a94637cfab8c776118084af90de663a2fc3e (link)

previous master: ab4bbeb07d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ab4bbeb (parent) -> d62fb1c (this PR)

Test differences

Show 8 test diffs

8 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d62fb1c8a007f6967376a52da8315ae51b64a70c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-gcc-core-tests: 7m 54s -> 14m 21s (+81.6%)
  2. aarch64-apple: 2h 9m -> 3h 27m (+60.7%)
  3. pr-check-1: 20m 35s -> 32m 27s (+57.5%)
  4. x86_64-msvc-ext1: 1h 43m -> 2h 25m (+41.0%)
  5. x86_64-msvc-1: 1h 59m -> 2h 46m (+39.4%)
  6. test-various: 1h 29m -> 2h 1m (+35.2%)
  7. tidy: 3m 30s -> 2m 18s (-34.1%)
  8. x86_64-msvc-ext3: 1h 23m -> 1h 49m (+31.3%)
  9. dist-x86_64-msvc: 1h 37m -> 2h 7m (+30.4%)
  10. x86_64-msvc-ext2: 1h 54m -> 1h 22m (-28.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (d62fb1c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.9% [-2.5%, -1.5%] 13
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -7.2%, secondary -14.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.2% [4.2%, 9.6%] 3
Improvements ✅
(primary)
-7.2% [-7.2%, -7.2%] 1
Improvements ✅
(secondary)
-19.5% [-22.8%, -11.7%] 13
All ❌✅ (primary) -7.2% [-7.2%, -7.2%] 1

Cycles

Results (primary -3.5%, secondary -12.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.5% [-4.3%, -2.6%] 2
Improvements ✅
(secondary)
-12.5% [-20.7%, -3.0%] 16
All ❌✅ (primary) -3.5% [-4.3%, -2.6%] 2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.393s -> 489.85s (0.09%)
Artifact size: 389.94 MiB -> 389.48 MiB (-0.12%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants