Move tests batch 18#159309
Open
danieljofficial wants to merge 2 commits into
Open
Conversation
Collaborator
|
This PR modifies |
rustbot
added
S-waiting-on-review
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Kivooeo
requested changes
Jul 15, 2026
rustbot
added
the
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Member
|
@bors r- |
rust-bors
Bot
removed
the
S-waiting-on-bors
Contributor
|
This pull request was unapproved. |
danieljofficial
force-pushed
the
move-tests-batch-18
branch
from
d1a3eb4 to
88ffb38
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
zedddie
reviewed
Jul 15, 2026
Comment on lines
+1
to
4
| // Regression test for https://github.com/rust-lang/rust/issues/60218 | ||
| // | ||
| // This was reported to cause ICEs. | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| // Regression test for https://github.com/rust-lang/rust/issues/60218 | |
| // | |
| // This was reported to cause ICEs. | |
| //! Regression test for https://github.com/rust-lang/rust/issues/60218 | |
| //! This was reported to cause ICEs. |
Comment on lines
1
to
+3
| //@ run-pass | ||
| // Regression test for an obscure issue with the projection cache. | ||
| // https://github.com/rust-lang/rust/issues/42552 |
Contributor
There was a problem hiding this comment.
Suggested change
| //@ run-pass | |
| // Regression test for an obscure issue with the projection cache. | |
| // https://github.com/rust-lang/rust/issues/42552 | |
| //! Regression test for an obscure issue with the projection cache. | |
| //! https://github.com/rust-lang/rust/issues/42552 | |
| //@ run-pass |
Contributor
|
My upcoming batch overlaps with some of these, glad I saw this so I can drop overlapping moves from my branch. |
zedddie
reviewed
Jul 15, 2026
Comment on lines
+1
to
13
| //! Regression test for https://github.com/rust-lang/rust/issues/39827 | ||
| //@ run-pass | ||
| #![feature(core_intrinsics)] | ||
|
|
||
| use std::intrinsics::{ volatile_copy_memory, volatile_store, volatile_load, | ||
| volatile_copy_nonoverlapping_memory, | ||
| volatile_set_memory }; | ||
|
|
||
| // | ||
| // This test ensures that volatile intrinsics can be specialised with | ||
| // zero-sized types and, in case of copy/set functions, can accept | ||
| // number of elements equal to zero. | ||
| // |
Contributor
There was a problem hiding this comment.
Suggested change
| //! Regression test for https://github.com/rust-lang/rust/issues/39827 | |
| //! This test ensures that volatile intrinsics can be specialised with | |
| //! zero-sized types and, in case of copy/set functions, can accept | |
| //! number of elements equal to zero. | |
| //@ run-pass | |
| #![feature(core_intrinsics)] | |
| use std::intrinsics::{ volatile_copy_memory, volatile_store, volatile_load, | |
| volatile_copy_nonoverlapping_memory, | |
| volatile_set_memory }; | |
Contributor
There was a problem hiding this comment.
(this one overlaps with one of my already open PRs)
zedddie
reviewed
Jul 15, 2026
Contributor
There was a problem hiding this comment.
this one doesn't seem to be a move (it also overlaps with #159308 which is already merged, so this will likely produce a duplicate).
Member
|
@rustbot author |
rustbot
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, a few more tests. Part of #133895
r? @Kivooeo